Skip to content

7903889: jcstress: document used properties (and env variables)#156

Open
judovana wants to merge 4 commits into
openjdk:masterfrom
judovana:propertiesToHelp
Open

7903889: jcstress: document used properties (and env variables)#156
judovana wants to merge 4 commits into
openjdk:masterfrom
judovana:propertiesToHelp

Conversation

@judovana

@judovana judovana commented Jan 4, 2025

Copy link
Copy Markdown

The purpose of this PR is to move properties and properties based initializations to single place, and to document them, and to enable printing the listing with the documentation via help.

No Env. vars were found.

The verbose help can be removed, the individual properties with defaults are wrapped to its class. The OptionSpec and OptionFormatter can be used if needed


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903889: jcstress: document used properties (and env variables) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.org/jcstress.git pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/156.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jan 4, 2025

Copy link
Copy Markdown

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jan 4, 2025

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jan 4, 2025
@openjdk

openjdk Bot commented Jan 4, 2025

Copy link
Copy Markdown

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@judovana judovana changed the title 7903889 - Known properties unifed in one class and printed in verbose help 7903889: jcstress: document used properites (and env variables) Jan 4, 2025
@mlbridge

mlbridge Bot commented Jan 4, 2025

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jan 4, 2025

Copy link
Copy Markdown

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk

openjdk Bot commented Jan 25, 2025

Copy link
Copy Markdown

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper

bridgekeeper Bot commented Feb 1, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

judovana commented Feb 1, 2025

Copy link
Copy Markdown
Author

...keep live...

@bridgekeeper

bridgekeeper Bot commented Mar 1, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

judovana commented Mar 3, 2025

Copy link
Copy Markdown
Author

More is coming!

@bridgekeeper

bridgekeeper Bot commented Mar 31, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

I still have faith!

@bridgekeeper

bridgekeeper Bot commented Apr 28, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

loosing faith:(

@judovana

Copy link
Copy Markdown
Author

../live..

@bridgekeeper

bridgekeeper Bot commented Jun 18, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

Faith restored!

judovana added 4 commits June 23, 2025 10:45
Known properties unifed in one class and printed in verbose help:
The verbose help can be removed, the individual properties with defaults
can be wrapped to its class. Even the OptionSpec and OptionFormatter can
be used if needed
@openjdk

openjdk Bot commented Jun 23, 2025

Copy link
Copy Markdown

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@judovana

Copy link
Copy Markdown
Author

faith restored

@bridgekeeper

bridgekeeper Bot commented Aug 13, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

Is there hope?

@bridgekeeper

bridgekeeper Bot commented Sep 12, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

Loosing the faith...

@bridgekeeper

bridgekeeper Bot commented Oct 10, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

Loosing the faith...

@bridgekeeper

bridgekeeper Bot commented Nov 10, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana judovana changed the title 7903889: jcstress: document used properites (and env variables) 7903889 jcstress: document used properties (and env variables) Nov 11, 2025
@openjdk openjdk Bot changed the title 7903889 jcstress: document used properties (and env variables) 7903889: jcstress: document used properties (and env variables) Nov 11, 2025
@judovana

Copy link
Copy Markdown
Author

@JarvisCraft feel free to eyball-)

@bridgekeeper

bridgekeeper Bot commented Dec 10, 2025

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author

Need for this still valid

@judovana

judovana commented Jan 8, 2026

Copy link
Copy Markdown
Author

keep alive

@bridgekeeper

bridgekeeper Bot commented Feb 5, 2026

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

judovana commented Feb 6, 2026

Copy link
Copy Markdown
Author
Once upon a midnight dreary, while I pondered, weak and weary,
Over many a quaint and curious volume of forgotten lore—
    While I nodded, nearly napping, suddenly there came a tapping,
As of some one gently rapping, rapping at my chamber door.
“’Tis some visitor,” I muttered, “tapping at my chamber door—
            Only this and nothing more.”

@bridgekeeper

bridgekeeper Bot commented Mar 6, 2026

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author
      Ah, distinctly I remember it was in the bleak December,
And each separate dying ember wrought its ghost upon the floor.
   Eagerly I wished the morrow;- vainly I had sought to borrow
From my books surcease of sorrow- sorrow for the lost Lenore-
For the rare and radiant maiden whom the angels name Lenore-
                 Nameless here for evermore. 

@bridgekeeper

bridgekeeper Bot commented Apr 13, 2026

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@judovana

Copy link
Copy Markdown
Author
 And the silken, sad, uncertain rustling of each purple curtain
Thrilled me—filled me with fantastic terrors never felt before;
    So that now, to still the beating of my heart, I stood repeating
    “’Tis some visitor entreating entrance at my chamber door—
Some late visitor entreating entrance at my chamber door;—
            This it is and nothing more.”

@bridgekeeper

bridgekeeper Bot commented May 26, 2026

Copy link
Copy Markdown

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@JarvisCraft

Copy link
Copy Markdown

BTW, have you tried writing to the mailing list of jcstress?

@judovana

Copy link
Copy Markdown
Author

Yes. I remember myself writing there few times. First message around July 2024 IIRC. However I do not recall any discussion actually happening there on any thread (mine or anybody)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants