7903671: jcstress: Update buffer tests for JDK-8318966#160
Conversation
|
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
Ah... not fulfilling its promises.... But about half passed. I guess Ihad picked up wrong subset for initial testing |
|
Reopening for a while... maye somebody around will know why. |
|
Ok. I made a much more deeper look, and consulted with Aph and Thomas, and this fix indeed looks wrong from all points of view. To reduce it to (1,1),except obvious failures, seesm to no longer check the issue. Also it seems that for jdk 23 and up, the correct replacement are direct buffers - which - feel free to correct me - are well covered in jcstress, Thus the correct fix seesm to be #159 or to remove the. Closing this in favour of #159 |
This is another possible fix for https://bugs.openjdk.org/browse/CODETOOLS-7903671 - : jcstress: Update buffer tests for JDK-8318966 (Bug - P4)
This one is attempting Experimental reduction of (0, 8) -> (0, 1) in all affected calls. Brief experiments seesm the change works. But whether it is still testing what it should.. I try to decrypt it, but up to now now proof.
I have not yet tested all affected tests. That is in progress.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/160/head:pull/160$ git checkout pull/160Update a local copy of the PR:
$ git checkout pull/160$ git pull https://git.openjdk.org/jcstress.git pull/160/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 160View PR using the GUI difftool:
$ git pr show -t 160Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/160.diff
Using Webrev
Link to Webrev Comment