7904128: Add a struct reinterpret helper that keeps scope#300
7904128: Add a struct reinterpret helper that keeps scope#300nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
|
@nizarbenalla This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
mcimadamore
left a comment
There was a problem hiding this comment.
In general, the change seems good. I'm a bit unsure re. compatibility impact -- the test changes shows that there's some code out there that might stop working. If we want to play extra safe we could keep all existing methods, and add a new one.
|
@nizarbenalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Please review this change to add a new reinterpret method that keeps scope, I have removed one of the old methods and only kept one with arena and cleanup, and one without.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/300/head:pull/300$ git checkout pull/300Update a local copy of the PR:
$ git checkout pull/300$ git pull https://git.openjdk.org/jextract.git pull/300/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 300View PR using the GUI difftool:
$ git pr show -t 300Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/300.diff
Using Webrev
Link to Webrev Comment