Skip to content

7904128: Add a struct reinterpret helper that keeps scope#300

Open
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla:7904128-reinterpret
Open

7904128: Add a struct reinterpret helper that keeps scope#300
nizarbenalla wants to merge 1 commit intoopenjdk:masterfrom
nizarbenalla:7904128-reinterpret

Conversation

@nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Feb 4, 2026

Please review this change to add a new reinterpret method that keeps scope, I have removed one of the old methods and only kept one with arena and cleanup, and one without.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.org/jextract.git pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/300.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2026

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@nizarbenalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904128: Add a struct reinterpret helper that keeps scope

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2026

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the change seems good. I'm a bit unsure re. compatibility impact -- the test changes shows that there's some code out there that might stop working. If we want to play extra safe we could keep all existing methods, and add a new one.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2026

@nizarbenalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants