-
Notifications
You must be signed in to change notification settings - Fork 143
8375548: [lworld] C2: Compiler replay does not work due to not creating ObjArrayKlass objects with ArrayProperties::DEFAULT #1931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chhagedorn
wants to merge
1
commit into
openjdk:lworld
Choose a base branch
from
chhagedorn:JDK-8375548
base: lworld
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
test/hotspot/jtreg/compiler/ciReplay/TestLoadObjArrayKlass.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @bug 8375548 | ||
| * @enablePreview | ||
| * @library / /test/lib | ||
| * @summary Testing that compiler replay correctly loads sub classes of ObjArrayKlass. | ||
| * @requires vm.flightRecorder != true & vm.compMode != "Xint" & vm.compMode != "Xcomp" & vm.debug == true & | ||
| * vm.compiler2.enabled | ||
| * @modules java.base/jdk.internal.misc | ||
| * @build jdk.test.whitebox.WhiteBox | ||
| * @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox | ||
| * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI | ||
| * compiler.ciReplay.TestLoadObjArrayKlass | ||
| */ | ||
|
|
||
| package compiler.ciReplay; | ||
|
|
||
| public class TestLoadObjArrayKlass extends DumpReplayBase { | ||
|
|
||
| public static void main(String[] args) { | ||
| new TestLoadObjArrayKlass().runTest("-XX:CompileCommand=dontinline,*::test", "--enable-preview", TIERED_DISABLED_VM_OPTION); | ||
| } | ||
|
|
||
| @Override | ||
| public void testAction() { | ||
| positiveTest(TIERED_DISABLED_VM_OPTION, "-XX:+ReplayIgnoreInitErrors", "--enable-preview"); | ||
| } | ||
|
|
||
| @Override | ||
| public String getTestClass() { | ||
| return TestLoadObjArrayKlassTest.class.getName(); | ||
| } | ||
| } | ||
|
|
||
| class TestLoadObjArrayKlassTest { | ||
| static Object[] oArr = new A[100]; | ||
|
|
||
| public static void main(String[] args) { | ||
| oArr[0] = new A(); | ||
| for (int i = 0; i < 10000; i++) { | ||
| test(); | ||
| } | ||
| } | ||
|
|
||
| static void test() { | ||
| Object[] oA = oArr; | ||
| Object o = oA[0]; | ||
| // Use the object with its speculated type. This triggers the code path to call | ||
| // | ||
| // Parse::create_speculative_inline_type_array_checks() | ||
| // ... | ||
| // ciArrayKlass::is_elem_null_free() | ||
| // | ||
| // which tries to directly query a ObjectArrayKlass instance in compiler replay instead of one of its subclasses | ||
| // (i.e. RefArrayKlass or FlatArrayKlass). This is unexpected and results in an assertion failure. | ||
| o.toString(); | ||
| } | ||
|
|
||
| static value class A { | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always create the default refined klass. Shouldn't we keep track of which refined klass was actually referenced in the replay file and then create that particular one here?