-
Notifications
You must be signed in to change notification settings - Fork 143
Classfile signature bang support #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
src/java.base/share/classes/java/lang/classfile/ClassSignature.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/classfile/ClassSignature.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/classfile/MethodSignature.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/jdk/internal/classfile/impl/SignaturesImpl.java
Show resolved
Hide resolved
mcimadamore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I've left some doc notes and some test comments
|
Thanks for the reviews! /integrate |
Support parsing ! signatures in ClassFile API.
Progress
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1933/head:pull/1933$ git checkout pull/1933Update a local copy of the PR:
$ git checkout pull/1933$ git pull https://git.openjdk.org/valhalla.git pull/1933/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1933View PR using the GUI difftool:
$ git pr show -t 1933Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1933.diff
Using Webrev
Link to Webrev Comment