Skip to content

Conversation

@liach
Copy link
Member

@liach liach commented Jan 19, 2026

Support parsing ! signatures in ClassFile API.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1933/head:pull/1933
$ git checkout pull/1933

Update a local copy of the PR:
$ git checkout pull/1933
$ git pull https://git.openjdk.org/valhalla.git pull/1933/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1933

View PR using the GUI difftool:
$ git pr show -t 1933

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1933.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2026

👋 Welcome back liach! A progress list of the required criteria for merging this PR into bworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 19, 2026

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Classfile signature bang support

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the bworld branch:

  • 4f31dc3: add different flavors to the useSiteNullChecks compiler option

Please see this link for an up-to-date comparison between the source branch of this pull request and the bworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the bworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2026

Webrevs

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I've left some doc notes and some test comments

@liach
Copy link
Member Author

liach commented Jan 21, 2026

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2026

Going to push as commit b9f91bd.
Since your change was applied there has been 1 commit pushed to the bworld branch:

  • 4f31dc3: add different flavors to the useSiteNullChecks compiler option

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2026
@openjdk openjdk bot closed this Jan 21, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2026
@openjdk
Copy link

openjdk bot commented Jan 21, 2026

@liach Pushed as commit b9f91bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants