8375740: [lworld] javap prints "value class" while class flags indicate ACC_IDENTITY

[liach]

Seems like an oversight where "value" is added unconditionally. I changed the behavior to add "identity" for preview identity classes, which was never printed before (because identity is not a source modifier)

Testing: langtools/tools/javap + javac

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8375740: [lworld] javap prints "value class" while class flags indicate ACC_IDENTITY (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1938/head:pull/1938
$ git checkout pull/1938

Update a local copy of the PR:
$ git checkout pull/1938
$ git pull https://git.openjdk.org/valhalla.git pull/1938/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1938

View PR using the GUI difftool:
$ git pr show -t 1938

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1938.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8375740: [lworld] javap prints "value class" while class flags indicate ACC_IDENTITY

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (50d7b76f)
• 00: Full (c06db063)

[vicente-romero-oracle]

lgtm

[vicente-romero-oracle]

nit, I would say probably better to print nothing if the class is identity and print value if it is a value class

[vicente-romero-oracle]

lgtm

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit fa557ef.

[openjdk]

@liach Pushed as commit fa557ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.