feat: support --domain on inbox create and init#13
Open
armandokun wants to merge 1 commit into
Open
Conversation
Add a --domain flag to `openmail inbox create` and `openmail init` so an agent can provision an inbox on a verified custom domain. Previously the CLI only sent mailboxName/displayName, so inboxes always landed on the account default domain even when a custom domain was set up. - forward --domain to POST /v1/inboxes - thread domain through resolveInboxCreateParams and init - update help text, README, CHANGELOG - add command tests for the flag Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--domain <domain>toopenmail inbox createandopenmail init, forwarding it toPOST /v1/inboxes.resolveInboxCreateParamsandinit.Why
From the Matagi/Aleks thread: their agent provisioned inboxes via the CLI/API but they landed on the default domain because there was no way to pass the custom domain. This adds the missing flag.
Test plan
npm run buildnpm test(5 passed, incl. newcommands/__tests__/inbox.test.ts)--domainis forwarded and omitted correctlyMade with Cursor