Move some logging code from MSSQL to generic SQL engine#2729
Merged
Conversation
evansd
force-pushed
the
evansd/refactor-logging
branch
from
cc0d13d to
fc91762
Compare
Deploying databuilder-docs with
|
| Latest commit: |
8757ad5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f63a6e58.databuilder.pages.dev |
| Branch Preview URL: | https://evansd-refactor-logging.databuilder.pages.dev |
evansd
force-pushed
the
evansd/refactor-logging
branch
from
fc91762 to
d6d7ac8
Compare
evansd
force-pushed
the
evansd/refactor-logging
branch
from
d6d7ac8 to
1fbbae4
Compare
rebkwok
approved these changes
Mar 30, 2026
This moves the logging code into the base SQL engine so that all SQL query engines benefit from it, not just the MSSQL one.
We also need to continue to support the old format so that we can parse historical logs.
evansd
force-pushed
the
evansd/refactor-logging
branch
from
1fbbae4 to
8757ad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that we get logging of the executed SQL and basic query timing for all SQL-based query engines, rather than just for MSSQL.