Update "that_user" codelists page to use Tailwind styles#3011
Update "that_user" codelists page to use Tailwind styles#3011
Conversation
76be9e2 to
bbf772f
Compare
mikerkelly
left a comment
There was a problem hiding this comment.
Thanks, Tom, this looks great.
I think that codelists-table.ts replaces codelists-list.js after #3011, is that right? That displayed multiple versions per codelist in one table, did we decide to drop that?
I think that the TypeScript search filter works well for our needs but if we wanted to keep developing this futher we might consider a pre-packaged dependency as a solution (DataTables or something more lightweight, I am not sure what is available), or possibly use HTMX to re-render a fragment server side to limit the amount of custom JavaScript and tests that we need to maintain, probably that would not be so responsive though.
I think an additional test for a successful multi-word search term could be useful to exercise the happy path of matchesAllWords with more search terms.
It will replace it when we update the "this_user" page, but at the moment
Agreed, if we go beyond a basic filter and sorting, to any type of per-column filtering, I'd rather reach for a dependency to handle it for us.
Good spot, I'll add a basic test for that now. |
Including updating the table and search input, using TypeScript, and adding tests.
that_user.htmlis used when logged in and viewing another user's profile, or logged out users viewing any profile.Part of #2981
Screenshots
Before
After