Skip to content

Update "that_user" codelists page to use Tailwind styles#3011

Merged
tomodwyer merged 7 commits intomainfrom
tomodwyer/other-users-codelists
Apr 2, 2026
Merged

Update "that_user" codelists page to use Tailwind styles#3011
tomodwyer merged 7 commits intomainfrom
tomodwyer/other-users-codelists

Conversation

@tomodwyer
Copy link
Copy Markdown
Member

@tomodwyer tomodwyer commented Mar 31, 2026

Including updating the table and search input, using TypeScript, and adding tests.

that_user.html is used when logged in and viewing another user's profile, or logged out users viewing any profile.

Part of #2981

Screenshots

Before

After

@tomodwyer tomodwyer self-assigned this Mar 31, 2026
@tomodwyer tomodwyer marked this pull request as ready for review March 31, 2026 12:36
@tomodwyer tomodwyer force-pushed the tomodwyer/other-users-codelists branch from 76be9e2 to bbf772f Compare April 1, 2026 10:19
Copy link
Copy Markdown
Contributor

@mikerkelly mikerkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tom, this looks great.

I think that codelists-table.ts replaces codelists-list.js after #3011, is that right? That displayed multiple versions per codelist in one table, did we decide to drop that?

I think that the TypeScript search filter works well for our needs but if we wanted to keep developing this futher we might consider a pre-packaged dependency as a solution (DataTables or something more lightweight, I am not sure what is available), or possibly use HTMX to re-render a fragment server side to limit the amount of custom JavaScript and tests that we need to maintain, probably that would not be so responsive though.

I think an additional test for a successful multi-word search term could be useful to exercise the happy path of matchesAllWords with more search terms.

@tomodwyer
Copy link
Copy Markdown
Member Author

I think that codelists-table.ts replaces codelists-list.js after #3011, is that right? That displayed multiple versions per codelist in one table, did we decide to drop that?

It will replace it when we update the "this_user" page, but at the moment codelists-list.js is required for that template.

if we wanted to keep developing this futher we might consider a pre-packaged dependency as a solution

Agreed, if we go beyond a basic filter and sorting, to any type of per-column filtering, I'd rather reach for a dependency to handle it for us.

I think an additional test for a successful multi-word search term could be useful to exercise the happy path of matchesAllWords with more search terms.

Good spot, I'll add a basic test for that now.

@tomodwyer tomodwyer merged commit 7fb63d4 into main Apr 2, 2026
6 checks passed
@tomodwyer tomodwyer deleted the tomodwyer/other-users-codelists branch April 2, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants