feat: Convert legacy templates to twig#399
Merged
Merged
Conversation
Signed-off-by: Kim Pepper <kim@pepper.id.au>
kimpepper
requested review from
VachaShah,
harshavamsi,
saimedhi and
shyim
as code owners
Signed-off-by: Kim Pepper <kim@pepper.id.au>
Signed-off-by: Kim Pepper <kim@pepper.id.au>
kimpepper
force-pushed
the
twig-templates
branch
from
2ba47d3 to
8ceac7b
Compare
shyim
reviewed
Mar 11, 2026
Signed-off-by: Kim Pepper <kim@pepper.id.au>
shyim
previously approved these changes
Mar 12, 2026
Collaborator
|
Thank you! |
Signed-off-by: Kim Pepper <kim@pepper.id.au>
Signed-off-by: Kim Pepper <kim@pepper.id.au>
shyim
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves from legacy templates that use
str_replace()to twig. Twig has a number of advantages including:{% if %}{% for %}{{ myobject.property }}{% extends "base.php" %}{% block foo %}This can simplify our current logic, and move simple if statements and loops to the templates themselves in the future.
Note: this introduced some extra whitespace, but our php-cs fixer did not seem to mind.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.