fix: handle unpaired UTF-16 surrogates in SmartSerializer#403
Merged
shyim merged 3 commits intoMay 8, 2026
Conversation
Signed-off-by: Kyoko OZAKI <kanz.anz10@gmail.com>
k-anz
requested review from
VachaShah,
harshavamsi,
kimpepper,
saimedhi and
shyim
as code owners
Signed-off-by: Kyoko OZAKI <kanz.anz10@gmail.com>
k-anz
force-pushed
the
fix-smartserializer-jsonexception
branch
from
929b8f7 to
2b8dcec
Compare
shyim
previously approved these changes
Apr 29, 2026
Collaborator
shyim
left a comment
shyim
left a comment
There was a problem hiding this comment.
fine for me as elastic client did the same
kimpepper
requested changes
Apr 29, 2026
Signed-off-by: Kyoko OZAKI <kanz.anz10@gmail.com>
kimpepper
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #402
Implements the same fix as elastic/elasticsearch-php#1179
Issues Resolved
#402
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.