Bulk module updates urns - #228
Conversation
e2de9c4 to
af24b00
Compare
|
|
||
| @DisplayInfo(label="UID Prefix", desc="Prefix to use for Things, Sensors and FOIs UIDs") | ||
| public String uidPrefix = "urn:osh:sta:"; | ||
| public String uidPrefix = "urn:osh:sensor:georobotix:sta:"; |
There was a problem hiding this comment.
It is tricky to make this generic change since this prefixes UIDs of Things, Sensors, and FOIs. You can check the usage of this config value in the entity handlers of this SensorThings service. Basically, the :foi or :thing or :sensor seems to be attached later, so this may be confusing when used practically.
There was a problem hiding this comment.
Valid options for the 3rd segment are
actuator | data | def | foi | process | sensor | system
To avoid confusion should I think using data as it comes from an STA appliance, but we do not know if it is a system or process
earocorn
left a comment
There was a problem hiding this comment.
Left some comments on URN prefixes that don't make sense when changed, so maybe just double check the actual usages of all the changed prefixes
5367086 to
5106485
Compare
5106485 to
b8b9881
Compare
This PR updates all URNs to ensure they follow the same base
urn:osh:[TYPE]:georobotix: