Skip to content

Bulk module updates urns - #228

Open
nickgaray wants to merge 9 commits into
opensensorhub:masterfrom
Botts-Innovative-Research:bulk_module_updates_urns
Open

Bulk module updates urns#228
nickgaray wants to merge 9 commits into
opensensorhub:masterfrom
Botts-Innovative-Research:bulk_module_updates_urns

Conversation

@nickgaray

Copy link
Copy Markdown
Collaborator

This PR updates all URNs to ensure they follow the same base

urn:osh:[TYPE]:georobotix:

@nickgaray
nickgaray marked this pull request as ready for review July 15, 2026 13:00
@nickgaray
nickgaray force-pushed the bulk_module_updates_urns branch from e2de9c4 to af24b00 Compare July 22, 2026 20:14

@DisplayInfo(label="UID Prefix", desc="Prefix to use for Things, Sensors and FOIs UIDs")
public String uidPrefix = "urn:osh:sta:";
public String uidPrefix = "urn:osh:sensor:georobotix:sta:";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is tricky to make this generic change since this prefixes UIDs of Things, Sensors, and FOIs. You can check the usage of this config value in the entity handlers of this SensorThings service. Basically, the :foi or :thing or :sensor seems to be attached later, so this may be confusing when used practically.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid options for the 3rd segment are
actuator | data | def | foi | process | sensor | system

To avoid confusion should I think using data as it comes from an STA appliance, but we do not know if it is a system or process

@earocorn earocorn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on URN prefixes that don't make sense when changed, so maybe just double check the actual usages of all the changed prefixes

@nickgaray
nickgaray force-pushed the bulk_module_updates_urns branch from 5367086 to 5106485 Compare August 24, 2026 19:43
@nickgaray
nickgaray force-pushed the bulk_module_updates_urns branch from 5106485 to b8b9881 Compare August 24, 2026 19:45
@nickgaray
nickgaray requested a review from drewbotts September 1, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants