Skip to content

fix(ModuleUtils): Safeguard setMDCAdapter call for logback-android compatibility #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CoreyAllenAudio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ModuleUtils): Safeguard setMDCAdapter call for logback-android compatibility #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion sensorhub-core/src/main/java/org/sensorhub/utils/ModuleUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,20 @@ public static Logger createModuleLogger(IModule<?> module)
{
LoggerContext logContext = new LoggerContext();
logContext.setName(FileUtils.safeFileName(moduleID));
logContext.setMDCAdapter(new LogbackMDCAdapter());
try
{
logContext.setMDCAdapter(new LogbackMDCAdapter());
}
catch (NoSuchMethodError e)
{
/*
* The logback-android 3.0.0 ships 1.4.x classes, which is why a call compiled against 1.5.13 finds nothing.
* The new 1.5 method, setMDCAdapter, will never resolve during runtime.
* The saved 1.4.x info used at runtime is still accessible thus we can skip the setMDCAdapter method.
* Once the latest logback-android project incorporates a 1.5.x release, this exception handling bracket can be removed.
*/
log.debug("The logback-android 3.0.0 ships 1.4.x classes. Bypassing a 1.5.x setMDCAdapter method will allow the old tech to exist.");
}
logContext.putProperty(LOG_MODULE_ID, FileUtils.safeFileName(moduleID));
logContext.putProperty(LOG_MODULE_NAME, module.getName());
new ContextInitializer(logContext).autoConfig();
Expand Down