fix: propagate SSA dry-run errors instead of falling back to SimpleDriftCheck#149
Merged
tiraboschi merged 1 commit intoopenshift-virtualization:mainfrom Apr 17, 2026
Merged
Conversation
…iftCheck When DetectDrift failed (e.g. due to a webhook TLS certificate issue during OLM cert rotation), the Patcher was falling back to SimpleDriftCheck, which compares the minimal rendered template against the fully webhook-defaulted live object and almost always reports drift. This caused a false-positive cascade into the thrashing detector, producing confusing "edit war" log messages and repeated reconciliation errors until the operator restarted. The fix propagates the DetectDrift error so controller-runtime backs off and retries with proper exponential backoff until the transient condition (e.g. cert rotation window) resolves naturally. Also introduces the driftChecker interface to allow injection of a mock in tests, and adds TestDetectDriftPropagatesClientError to pin this behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DetectDrift failed (e.g. due to a webhook TLS certificate issue during OLM cert rotation), the Patcher was falling back to SimpleDriftCheck, which compares the minimal rendered template against the fully webhook-defaulted live object and almost always reports drift. This caused a false-positive cascade into the thrashing detector, producing confusing "edit war" log messages and repeated reconciliation errors until the operator restarted.
The fix propagates the DetectDrift error so controller-runtime backs off and retries with proper exponential backoff until the transient condition (e.g. cert rotation window) resolves naturally.
Also introduces the driftChecker interface to allow injection of a mock in tests, and adds TestDetectDriftPropagatesClientError to pin this behavior.