Skip to content

feat: add 37 InflightOperations OperationRuleSet assets#150

Merged
tiraboschi merged 2 commits intoopenshift-virtualization:mainfrom
mansam:add-ifo-rules
Apr 22, 2026
Merged

feat: add 37 InflightOperations OperationRuleSet assets#150
tiraboschi merged 2 commits intoopenshift-virtualization:mainfrom
mansam:add-ifo-rules

Conversation

@mansam
Copy link
Copy Markdown
Contributor

@mansam mansam commented Apr 17, 2026

Add OperationRuleSet CRs from the inflightoperations project as managed assets, gated by the IFO CRD. All 37 rules are phase 2, reconcile_order 20, grouped under "inflightoperations". RBAC updated with operationrulesets permissions.

@tiraboschi Is there a more compact way for me to create the assets than one file per OperationRuleset? I saw that there is a function for parsing multi-document yaml, but it doesn't appear to be used.

I used phase 2 and reconcile_order 2 based on my understanding of the documentation for adding new assets, since this is a tech preview feature.

If I understand properly, the platform.kubevirt.io/autopilot allowlist does gating by group, so I didn't set up any conditions other than a CRD gate. Let me know if I missed something.

Add OperationRuleSet CRs from the inflightoperations project as managed
assets, gated by the IFO CRD. All 37 rules are phase 2, reconcile_order
20, grouped under "inflightoperations". RBAC updated with
operationrulesets permissions.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@tiraboschi
Copy link
Copy Markdown
Collaborator

Thanks for the contribution!

@tiraboschi Is there a more compact way for me to create the assets than one file per OperationRuleset? I saw that there is a function for parsing multi-document yaml, but it doesn't appear to be used.

Good point, I filed an issue to track it: #151

I used phase 2 and reconcile_order 2 based on my understanding of the documentation for adding new assets, since this is a tech preview feature.

Great.

If I understand properly, the platform.kubevirt.io/autopilot allowlist does gating by group, so I didn't set up any conditions other than a CRD gate. Let me know if I missed something.

Fine.

Could you please also add a couple of lines in hack/update-crds.sh to fetch the operationrulesets.ifo.kubevirt.io CRD from its repo and save it under test/crds? It's not used at runtime nor shipped in the release image, but having an up-to-date CRD there is still useful for validation and tests on Kind clusters without needing to fully deploy third-party operators.

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@tiraboschi tiraboschi merged commit bf4d7a3 into openshift-virtualization:main Apr 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants