Skip to content

OCPBUGS-90135: Reduce parallelism for oc mirror#727

Merged
danielerez merged 1 commit into
openshift:masterfrom
bfournie:mirror-parallel
Jun 25, 2026
Merged

OCPBUGS-90135: Reduce parallelism for oc mirror#727
danielerez merged 1 commit into
openshift:masterfrom
bfournie:mirror-parallel

Conversation

@bfournie

@bfournie bfournie commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The fix #722 increased the retry times to help allievate the oc mirror failures; this helped but didn't resolve the issue. Decrease the parallel images being used to attempt to increase reliability of this command. Also add a retry mechanism on the entire oc command.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-90135, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The fix #722 increased the retry times to help allievate the oc mirror failures; this helped but didn't resolve the issue. Decrease the parallel images being used to attempt to increase reliability of this command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from andfasano and gamli75 June 23, 2026 17:33
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-90135, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

The fix #722 increased the retry times to help allievate the oc mirror failures; this helped but didn't resolve the issue. Decrease the parallel images being used to attempt to increase reliability of this command. Also add a retry mechanism on the entire oc command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano

Copy link
Copy Markdown
Contributor
ISOBuilder execution time: 56m 44s

It's really a big jump from the current ~22m

Comment thread pkg/release/release.go Outdated
templateImageExtract = "oc image extract --path %s:%s --confirm %s"
templateGetMetadata = "oc adm release info %s -o json"
ocMirror = "oc mirror --v2 --config=%s docker://127.0.0.1:%d --workspace=file://%s --src-tls-verify=false --dest-tls-verify=false --parallel-images=4 --parallel-layers=4 --retry-times=10"
ocMirror = "oc mirror --v2 --config=%s docker://127.0.0.1:%d --workspace=file://%s --src-tls-verify=false --dest-tls-verify=false --parallel-images=2 --parallel-layers=4 --retry-times=5"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try with --parallel-images=3

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try that. Updated. We'll see the affect on execution time

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using parallel-images=3...
2026-06-24 09:08:51 ISOBuilder execution time: 40m 46s

The fix openshift#722 increased the
retry times to help allievate the oc mirror failures; this helped
but didn't resolve the issue. Decrease the parallel images being
used to attempt to increase reliability of this command.
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andfasano

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026
@zaneb

zaneb commented Jun 25, 2026

Copy link
Copy Markdown
Member

Based on the logs I'm not convinced this is gonna help. A single dropped connection will kill the whole mirroring, and I can't immediately think of a reason that having fewer connections in parallel makes it less likely for one to be dropped (unless Akamai thinks we're part of a DDOS?).

@danielerez danielerez merged commit deb30df into openshift:master Jun 25, 2026
6 of 9 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@bfournie: Jira Issue OCPBUGS-90135: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-90135 has not been moved to the MODIFIED state.

Details

In response to this:

The fix #722 increased the retry times to help allievate the oc mirror failures; this helped but didn't resolve the issue. Decrease the parallel images being used to attempt to increase reliability of this command. Also add a retry mechanism on the entire oc command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano

Copy link
Copy Markdown
Contributor

Based on the logs I'm not convinced this is gonna help. A single dropped connection will kill the whole mirroring, and I can't immediately think of a reason that having fewer connections in parallel makes it less likely for one to be dropped (unless Akamai thinks we're part of a DDOS?).

Let's test it directly now with the multi-pr. If not, we'll revert it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants