Skip to content

Conversation

@DavidHurta
Copy link
Contributor

@DavidHurta DavidHurta commented Jan 20, 2026

The newly added OKD feature set breaks down cluster installations due to the render logic not being aware of the feature set's existence.

Add the filtering logic and bump openshift/api, which includes the CVO OKD manifest files.

The bump commit is cherry-picked from #1288, which is required for #1284.

@DavidHurta
Copy link
Contributor Author

/hold

Do Not Merge

@DavidHurta DavidHurta changed the title TEST: pkg/payload/render: Add OKD feature set logic Do Not Merge: pkg/payload/render: Add OKD feature set logic Jan 20, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Walkthrough

Adds OKD to the list of manifest filenames skipped during bootstrap rendering in the payload module, and updates module dependency versions in go.mod.

Changes

Cohort / File(s) Summary
Bootstrap manifest skip logic
pkg/payload/render.go
Added OKD to the conditional that skips manifest files during bootstrap rendering; updated explanatory comment to include OKD.
Dependency bumps
go.mod
Updated multiple module requirements and indirect dependencies (OpenShift-related modules and various golang.org/x/* modules) to newer versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2026
@DavidHurta DavidHurta marked this pull request as draft January 20, 2026 14:07
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@DavidHurta
Copy link
Contributor Author

/test all

@hongkailiu
Copy link
Member

/test e2e-agnostic-operator

@hongkailiu
Copy link
Member

Let us see if openshift/hypershift#7557 fixes the HyperShift part.

@hongkailiu
Copy link
Member

/retest-required

@hongkailiu
Copy link
Member

Big difference.
e2e-hypershift is green.

e2e-hypershift-conformance is still red but it failed much later than the previous runs. I hope it is just regular flaky.

/test e2e-hypershift-conformance

@hongkailiu
Copy link
Member

/retitle NO-JIRA: pkg/payload/render: Add OKD feature set logic

@openshift-ci openshift-ci bot changed the title Do Not Merge: pkg/payload/render: Add OKD feature set logic NO-JIRA: pkg/payload/render: Add OKD feature set logic Jan 22, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [DavidHurta,hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu
Copy link
Member

Previously failing presubmits are all successful now.

/verified by @hongkailiu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

Previously failing presubmits are all successful now.

/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta DavidHurta changed the title NO-JIRA: pkg/payload/render: Add OKD feature set logic NO-JIRA: Add OKD feature set filtering logic, Bump openshift/api Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request explicitly references no jira issue.

Details

In response to this:

The newly added OKD feature set breaks down cluster installations due to the render logic not being aware of the feature set's existence.

Add the filtering logic and bump openshift/api, which includes the CVO OKD manifest files.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta DavidHurta marked this pull request as ready for review January 22, 2026 13:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2026
@DavidHurta DavidHurta changed the title NO-JIRA: Add OKD feature set filtering logic, Bump openshift/api OTA-1546: Add OKD feature set filtering logic, Bump openshift/api Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2026

@DavidHurta: This pull request references OTA-1546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The newly added OKD feature set breaks down cluster installations due to the render logic not being aware of the feature set's existence.

Add the filtering logic and bump openshift/api, which includes the CVO OKD manifest files.

The bump commit is cherry-picked from #1288

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2026

@DavidHurta: This pull request references OTA-1546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The newly added OKD feature set breaks down cluster installations due to the render logic not being aware of the feature set's existence.

Add the filtering logic and bump openshift/api, which includes the CVO OKD manifest files.

The bump commit is cherry-picked from #1288, which is required for #1284.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta DavidHurta changed the title OTA-1546: Add OKD feature set filtering logic, Bump openshift/api OTA-1833, OTA-1546: Add OKD feature set filtering logic, Bump openshift/api Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2026

@DavidHurta: This pull request references OTA-1833 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

This pull request references OTA-1546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The newly added OKD feature set breaks down cluster installations due to the render logic not being aware of the feature set's existence.

Add the filtering logic and bump openshift/api, which includes the CVO OKD manifest files.

The bump commit is cherry-picked from #1288, which is required for #1284.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2026
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4c7462f and 2 for PR HEAD dd3b833 in total

@hongkailiu
Copy link
Member

/test e2e-agnostic-ovn

1 similar comment
@hongkailiu
Copy link
Member

/test e2e-agnostic-ovn

@hongkailiu
Copy link
Member

/test e2e-agnostic-ovn

b05 is in trouble and now blocked. let us try again.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@DavidHurta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8802931 into openshift:main Jan 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants