Skip to content

Set DOCKER_API_VERSION=1.44 for conformance tests #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 30, 2026
Merged

Set DOCKER_API_VERSION=1.44 for conformance tests #317

openshift-merge-bot merged 1 commit into from
Jan 30, 2026
+4 −13

Conversation

@nalind
Copy link
Member

@nalind nalind commented Jan 26, 2026 •
edited
Loading

  • The default requested API version from go-dockerclient is considered too old by dockerd, so set it for CI and in how we suggest people run them locally.
  • Switch from jammy (22.04) to noble (24.04) as the test environment.
  • Bump the version of Go we use to 1.23; 1.22 is no longer supported.
  • Stop attempting to notify an IRC channel that the repo maintainers aren't watching.
  • Test with the version of dockerd included in noble instead of installing something from upstream.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@nalind nalind force-pushed the travis-1.44 branch 3 times, most recently from 3d27893 to c771b07 Compare January 27, 2026 22:59
TomSweeneyRedHat
TomSweeneyRedHat reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon mentioned this pull request Jan 28, 2026
Open
@jlebon
Copy link
Member

jlebon commented Jan 28, 2026

This fixes one of the Travis CI tests, but the other has a bunch of failures like:

conformance_test.go:168: error: preparing stage using "" as base: unable to start build container: API error (400): failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: open sysctl net.ipv4.ip_unprivileged_port_start file: reopen fd 8: permission denied

which smells like seccomp or AppArmor perhaps.

@nalind
Copy link
Member Author

nalind commented Jan 28, 2026 •
edited
Loading

Per #316 (comment).
Opened openshift/release#74094 to use the same version of the compiler for both test jobs.

@nalind
Set DOCKER_API_VERSION=1.44 for conformance tests
95d9af6 
The default requested API version from go-dockerclient is considered too
old by dockerd, so set it for CI and in how we suggest people run them
locally.

Switch from jammy (22.04) to noble (24.04) as the test environment.

Bump the version of Go we use to 1.23, as 1.22 is no longer supported.
1.23 isn't either, but we're waiting on being able to run the unit tests
with 1.24, too.

Stop attempting to notify an IRC channel that the repo maintainers
aren't watching.

Test with the version of dockerd included in noble instead of installing
something from upstream.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nalind
Copy link
Member Author

nalind commented Jan 29, 2026

Had to back down to 1.23 because the OpenShift end of things doesn't appear to have 1.24 yet.

@nalind nalind mentioned this pull request Jan 29, 2026
Open
@jlebon
Copy link
Member

jlebon commented Jan 30, 2026

Looks sane to me! I don't think this'll work but

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Jan 30, 2026

:surprised-pikachu:

I guess possibly it works because I'm in the OpenShift org? Not sure.

@openshift-merge-bot openshift-merge-bot bot merged commit b0fa389 into openshift:master Jan 30, 2026
3 checks passed
@nalind nalind deleted the travis-1.44 branch January 30, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

1 more reviewer

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jlebon jlebon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nalind @jlebon @TomSweeneyRedHat