[release-4.18] OCPBUGS-95616: azure: Add field in installconfig to disallow shared access key by rna-afk · Pull Request #10670 · openshift/installer

rna-afk · 2026-07-01T17:52:16Z

Since this needs to be backported to earlier versions, adding a
field to disallow shared access key if necessary.

Made the field negative type field to have the default be enabled for
shared key access for earlier versions.

- When using a managed identity, don't use shared key credentials - SAS urls are not supported in this case, so just return the blob URL https://issues.redhat.com/browse/OCPBUGS-37587 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Since this needs to be backported to earlier versions, adding a field to disallow shared access key if necessary. Made the field negative type field to have the default be enabled for shared key access for earlier versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-07-01T17:52:22Z

@rna-afk: This pull request references Jira Issue OCPBUGS-95616, which is invalid:

expected Jira Issue OCPBUGS-95616 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Since this needs to be backported to earlier versions, adding a
field to disallow shared access key if necessary.

Made the field negative type field to have the default be enabled for
shared key access for earlier versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-01T17:52:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 480f6c00-fddf-4d6a-9790-1487e711b2a3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

rna-afk · 2026-07-01T17:53:23Z

/jira refresh

openshift-ci-robot · 2026-07-01T17:53:28Z

@rna-afk: This pull request references Jira Issue OCPBUGS-95616, which is invalid:

expected Jira Issue OCPBUGS-95616 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rna-afk · 2026-07-01T17:54:29Z

/jira refresh

openshift-ci-robot · 2026-07-01T17:54:37Z

@rna-afk: This pull request references Jira Issue OCPBUGS-95616, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.z) matches configured target version for branch (4.18.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-91984 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-91984 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rna-afk · 2026-07-01T17:55:17Z

/verified by me locally with 2 scenarios, with allowSharedKeyAccess: true and false

openshift-ci-robot · 2026-07-01T17:55:30Z

@rna-afk: This PR has been marked as verified by me locally with 2 scenarios,with allowSharedKeyAccess: true and false.

Details

In response to this:

/verified by me locally with 2 scenarios, with allowSharedKeyAccess: true and false

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2026-07-01T18:46:24Z

/retest

sadasu · 2026-07-01T18:46:34Z

/approve

openshift-ci · 2026-07-01T18:46:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rna-afk · 2026-07-01T21:35:27Z

/retest

rna-afk · 2026-07-02T15:03:56Z

/retest

openshift-ci · 2026-07-02T15:41:35Z

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azurestack	`51e11f8`	link	false	`/test e2e-azurestack`
ci/prow/azure-ovn-marketplace-images	`51e11f8`	link	false	`/test azure-ovn-marketplace-images`
ci/prow/e2e-aws-ovn	`51e11f8`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-azure-ovn	`51e11f8`	link	true	`/test e2e-azure-ovn`
ci/prow/e2e-azure-default-config	`51e11f8`	link	false	`/test e2e-azure-default-config`
ci/prow/images	`51e11f8`	link	true	`/test images`
ci/prow/e2e-azure-ovn-shared-vpc	`51e11f8`	link	false	`/test e2e-azure-ovn-shared-vpc`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jhixson74 and others added 2 commits July 1, 2026 10:55

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 1, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 1, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 1, 2026

openshift-ci Bot requested review from mtulio and sadasu July 1, 2026 17:55

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 1, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026

Uh oh!

Conversation

rna-afk commented Jul 1, 2026

Uh oh!

openshift-ci-robot commented Jul 1, 2026

Uh oh!

coderabbitai Bot commented Jul 1, 2026

Review skipped

Uh oh!

rna-afk commented Jul 1, 2026

Uh oh!

openshift-ci-robot commented Jul 1, 2026

Uh oh!

rna-afk commented Jul 1, 2026

Uh oh!

openshift-ci-robot commented Jul 1, 2026

Uh oh!

rna-afk commented Jul 1, 2026

Uh oh!

openshift-ci-robot commented Jul 1, 2026

Uh oh!

sadasu commented Jul 1, 2026

Uh oh!

sadasu commented Jul 1, 2026

Uh oh!

openshift-ci Bot commented Jul 1, 2026

Uh oh!

rna-afk commented Jul 1, 2026

Uh oh!

rna-afk commented Jul 2, 2026

Uh oh!

openshift-ci Bot commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants