Use --no-color ginkgo option for upstream e2e

[cpmeadors]

This PR adds the --no-color option to the ginkgo execution of the upstream e2e tests. This makes reading the logs in Prow much easier.

Verification can be done by looking at the output of a local "make e2e-upstream-test" and the prow logs from Ci jobs to make sure there are no colors or ANSI characters showing up.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cpmeadors]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

I kinda like the color. It helps pop the errors.

Why do you want to disable it?

[cpmeadors]

I kinda like the color. It helps pop the errors.

Why do you want to disable it?

For local execution, I agree. My intention was to only disable colors for CI cases. Will have to pass options to the script.

[cpmeadors]

ci/prow/test-e2e-4-18 failed but it showed that it was running with --no-color

[cpmeadors]

"[It] should allow to update the PodTemplate in LeaderWorkerSet" failed due to timeout

[cpmeadors]

/override ci/prow/test-e2e-4-18

[openshift-ci]

@cpmeadors: Overrode contexts on behalf of cpmeadors: ci/prow/test-e2e-4-18

Details

In response to this:

/override ci/prow/test-e2e-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cpmeadors]

test test-e2e-upstream-4-20

[cpmeadors]

/test test-e2e-upstream-4-20

[cpmeadors]

Maybe this option needs to be passed in from the prow job. I thought we had a separate ci and local make target for upstream e2e. That pattern is messy.

[cpmeadors]

/hold

[openshift-ci]

@cpmeadors: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/test-e2e-4-20	0481bd4	link	true	/test test-e2e-4-20
ci/prow/test-e2e-downstream-4-21	0481bd4	link	true	/test test-e2e-downstream-4-21
ci/prow/test-e2e-upstream-4-21	0481bd4	link	true	/test test-e2e-upstream-4-21

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.