Skip to content

Potentially fix "should allow to label pod and job with default localqueue after they're created"#1140

Open
kannon92 wants to merge 1 commit intoopenshift:mainfrom
kannon92:localqueue-wait-for-deletion
Open

Potentially fix "should allow to label pod and job with default localqueue after they're created"#1140
kannon92 wants to merge 1 commit intoopenshift:mainfrom
kannon92:localqueue-wait-for-deletion

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Nov 26, 2025

I'm seeing a flake in "should allow to label pod and job with default localqueue after they're created" where there is an error in deletion of the local queue.

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_kueue-operator/1132/pull-ci-openshift-kueue-operator-main-test-e2e-4-18/1993750755021950976/build-log.txt

  {"level":"Level(-2)","ts":"2025-11-26T19:10:08.082417341Z","logger":"localqueue-reconciler","caller":"core/localqueue_controller.go:221","msg":"LocalQueue delete event","localQueue":{"name":"default","namespace":"e2e-kueue-5zgxc"}}
  2025/11/26 19:10:08 http: TLS handshake error from 10.130.0.2:58798: EOF
  {"level":"error","ts":"2025-11-26T19:10:08.093087795Z","caller":"controller/controller.go:474","msg":"Reconciler error","controller":"localqueue_controller","namespace":"e2e-kueue-5zgxc","name":"default","reconcileID":"8a1b3dc6-1b3a-42f9-91da-ebe63f4bb495","error":"Operation cannot be fulfilled on localqueues.kueue.x-k8s.io \"default\": StorageError: invalid object, Code: 4, Key: /kubernetes.io/kueue.x-k8s.io/localqueues/e2e-kueue-5zgxc/default, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: 65407d83-d8c6-48dd-baa1-ba7bdcded2f3, UID in object meta: ","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/workspace/upstream/kueue/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:474\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/workspace/upstream/kueue/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:421\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1\n\t/workspace/upstream/kueue/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:296"}

For some reason, the deletion has an error. The deletion registers so I am curious if we make sure deletion occurs this would deflake this test.

@openshift-ci openshift-ci bot requested review from mrunalp and rphillips November 26, 2025 20:44
@openshift-ci
Copy link

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@kannon92 kannon92 changed the title delete local queue and confirm its deleted Potentially fix "should allow to label pod and job with default localqueue after they're created" Nov 26, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-4-18 85cc963 link true /test test-e2e-4-18
ci/prow/test-e2e-upstream-4-21 85cc963 link true /test test-e2e-upstream-4-21

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant