Skip to content

WIP: Enable metrics in our upstream test suite#1511

Open
kannon92 wants to merge 1 commit intoopenshift:mainfrom
kannon92:enable-metrics-kueue
Open

WIP: Enable metrics in our upstream test suite#1511
kannon92 wants to merge 1 commit intoopenshift:mainfrom
kannon92:enable-metrics-kueue

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Feb 19, 2026

https://issues.redhat.com/browse/OCPKUEUE-547

Summary by CodeRabbit

  • Tests
    • Expanded end-to-end test coverage to include metrics-related test validation.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The pull request extends the GINKGO_ARGS label-filter in the e2e test OpenShift script by adding feature:metrics to the existing feature:visibility label filter, modifying which end-to-end tests are executed.

Changes

Cohort / File(s) Summary
E2E Test Configuration
upstream/kueue/e2e-test-ocp.sh
Extended GINKGO_ARGS label-filter by adding feature:metrics to the existing feature label selection criteria.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: enabling metrics in the upstream test suite, which directly aligns with the changeset modification to add feature:metrics to the Ginkgo test labels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR modifies only a shell script that configures Ginkgo test execution with label filters. No test name definitions (It, Describe, etc.) are added or modified.
Test Structure And Quality ✅ Passed Pull request modifies only a shell script configuration file that selects pre-existing tests via Ginkgo label filters, not test code itself.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-upstream-4-20 4ea01ae link true /test test-e2e-upstream-4-20
ci/prow/test-e2e-downstream-4-21 4ea01ae link true /test test-e2e-downstream-4-21
ci/prow/test-e2e-upstream-4-21 4ea01ae link true /test test-e2e-upstream-4-21

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant