OU-1472: run only changed tests by PeterYurkovich · Pull Request #1134 · openshift/monitoring-plugin

PeterYurkovich · 2026-08-12T19:39:27Z

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

openshift-merge-bot · 2026-08-12T19:39:30Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-12T19:39:31Z

@PeterYurkovich: This pull request references OU-1472 which is a valid jira issue.

Details

In response to this:

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-12T19:41:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [PeterYurkovich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jgbernalp · 2026-08-17T10:43:18Z

@@ -0,0 +1,62 @@
+#!/bin/bash
+
+CHANGED_FILES=$(git diff --name-only origin/main...HEAD)


The target branch might be different we should provide it from env defaulting to main

we should add error handling, in shallow checkouts the main branch might not exist.

jgbernalp · 2026-08-17T10:50:03Z

-    "test-cypress-perses-dev": "node --max-old-space-size=4096 ./node_modules/.bin/cypress run --browser chrome --headless --env grepTags='@perses-dashboards --@xfail'",
-    "test-cypress-perses": "node --max-old-space-size=4096 ./node_modules/.bin/cypress run --browser chrome --headless --env grepTags='@perses-dashboards --@smoke --@flaky --@xfail'",
-    "test-cypress-perses-ivt": "node --max-old-space-size=4096 ./node_modules/.bin/cypress run --browser chrome --headless --env grepTags='@perses-dashboards --@smoke --@flaky --@xfail'",
+    "test-cypress-monitoring": "../scripts/run-selective-e2e.sh",


Is this script in a different PR or should be ./cypress/run-changed.sh

jgbernalp · 2026-08-17T10:52:37Z

+if [ "$RUN_ALL" = true ]; then
+    echo "Changes affect global scope or unmapped features. Running ALL monitoring tests..."
+
+    DEFAULT_TAGS="@alerting @legacy-dashboards @metrics @targets acm-alerting @cluster-health-analyzer @perses-dashboards --@flaky --@xfail"


Suggested change

DEFAULT_TAGS="@alerting @legacy-dashboards @metrics @targets acm-alerting @cluster-health-analyzer @perses-dashboards --@flaky --@xfail"

DEFAULT_TAGS="@alerting @legacy-dashboards @metrics @targets @acm-alerting @cluster-health-analyzer @perses-dashboards --@flaky --@xfail"

jgbernalp · 2026-08-17T10:53:43Z

    "test": "npm run cypress:run:ci",
-    "test-cypress-console": "./node_modules/.bin/cypress open --browser chrome",
-    "test-cypress-console-headless": "node --max-old-space-size=4096 ./node_modules/.bin/cypress run --browser chrome --headless",
-    "test-cypress-monitoring": "node --max-old-space-size=4096 ./node_modules/.bin/cypress run --browser chrome --headless --env grepTags='@alerting+@legacy-dashboards+@metrics+@targets --@flaky --@xfail'",


Do we need to update the cypress docs with these removals?

jgbernalp · 2026-08-17T10:57:47Z

+CHANGED_FILES=$(git diff --name-only origin/main...HEAD)
+
+RUN_ALL=false
+declare -A TAGS_TO_RUN


We might need to change this into something POSIX compatible, I got the following issue while trying to run on mac:

./cypress/run-changed.sh: line 6: declare: -A: invalid option declare: usage: declare [-afFirtx] [-p] [name[=value] ...]

jgbernalp · 2026-08-17T10:59:27Z

+done
+
+if [ "$RUN_ALL" = true ]; then
+    echo "Changes affect global scope or unmapped features. Running ALL monitoring tests..."


unmapped features already exits

Suggested change

echo "Changes affect global scope or unmapped features. Running ALL monitoring tests..."

echo "Changes affect global scope. Running ALL monitoring tests..."

jgbernalp · 2026-08-17T11:00:59Z

+FEATURE_MAP["perses-dashboards"]="@perses-dashboards"
+FEATURE_MAP["targets"]="@targets"
+
+for FILE in $CHANGED_FILES; do


not sure if we have file paths with white spaces, but this will split on white space

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2026

openshift-ci Bot requested review from etmurasaki and jgbernalp August 12, 2026 19:40

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2026

PeterYurkovich force-pushed the run-changes branch from 4e1102d to 3335c07 Compare August 12, 2026 20:01

PeterYurkovich force-pushed the run-changes branch from 3335c07 to 217d32c Compare August 12, 2026 20:06

jgbernalp reviewed Aug 17, 2026

View reviewed changes

PeterYurkovich force-pushed the run-changes branch 2 times, most recently from 2c3cc81 to 88ad602 Compare August 17, 2026 13:35

feat: run only changed tests

49d7ac8

PeterYurkovich force-pushed the run-changes branch from 88ad602 to 49d7ac8 Compare August 17, 2026 19:07

Navigation Menu

Uh oh!

OU-1472: run only changed tests - #1134

OU-1472: run only changed tests#1134
PeterYurkovich wants to merge 1 commit into
move-viewsfrom
run-changes

PeterYurkovich commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

openshift-ci-robot commented Aug 12, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

jgbernalp Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,62 @@
		#!/bin/bash

		CHANGED_FILES=$(git diff --name-only origin/main...HEAD)

	DEFAULT_TAGS="@alerting @legacy-dashboards @metrics @targets acm-alerting @cluster-health-analyzer @perses-dashboards --@flaky --@xfail"
	DEFAULT_TAGS="@alerting @legacy-dashboards @metrics @targets @acm-alerting @cluster-health-analyzer @perses-dashboards --@flaky --@xfail"

	echo "Changes affect global scope or unmapped features. Running ALL monitoring tests..."
	echo "Changes affect global scope. Running ALL monitoring tests..."

Uh oh!

Conversation

PeterYurkovich commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

openshift-ci-robot commented Aug 12, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openshift-ci-robot commented Aug 12, 2026 •

edited by openshift-ci Bot

Loading