Bump the k8s group across 1 directory with 2 updates#1458
Bump the k8s group across 1 directory with 2 updates#1458dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the k8s group with 2 updates in the / directory: [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl). Updates `k8s.io/apimachinery` from 0.35.4 to 0.36.2 - [Commits](kubernetes/apimachinery@v0.35.4...v0.36.2) Updates `k8s.io/kubectl` from 0.35.0 to 0.36.2 - [Commits](kubernetes/kubectl@v0.35.0...v0.36.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-version: 0.36.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s - dependency-name: k8s.io/kubectl dependency-version: 0.36.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s ... Signed-off-by: dependabot[bot] <support@github.com>
WalkthroughThis PR updates go.mod: the Go toolchain moves from 1.25.7 to 1.26.0, core Kubernetes modules (k8s.io/api, apimachinery, client-go, kubectl) are bumped to v0.36.2, several indirect dependencies are updated, and two indirect requirements (go-cmp, httpcache) are removed. ChangesDependency Version Updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: review_needed_junior_swe, review_depth_standard Suggested reviewers: N/A Poem: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: The Go toolchain version is inconsistent between the module config and
the Docker build image. Update the version pin in go.mod and the matching
toolchain download/version reference in the Dockerfile so both use the same Go
release, keeping the change centered on the go directive and the Dockerfile
installation setup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8aa11d5c-a260-4403-af65-737ef533a00b
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift/oc-mirror/v2 | ||
|
|
||
| go 1.25.7 | ||
| go 1.26.0 |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== go.mod =="
git ls-files go.mod && sed -n '1,20p' go.mod
echo
echo "== Dockerfile candidates =="
git ls-files | rg '(^|/)(Dockerfile|dockerfile|.*Dockerfile.*)$' || true
echo
echo "== Go version/toolchain references =="
rg -n --hidden --glob '!**/vendor/**' --glob '!**/.git/**' \
'\bgo1\.[0-9]+(\.[0-9]+)?\b|\bgo [0-9]+\.[0-9]+(\.[0-9]+)?\b|GOVERSION|GO_VERSION|toolchain ' \
. || trueRepository: openshift/oc-mirror
Length of output: 4575
Align the Go toolchain pin before merging.
go 1.26.0 conflicts with the repo’s Dockerfile, which still downloads go1.23.5, so builds using that image will fail until the toolchain version is updated to match.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 3, The Go toolchain version is inconsistent between the
module config and the Docker build image. Update the version pin in go.mod and
the matching toolchain download/version reference in the Dockerfile so both use
the same Go release, keeping the change centered on the go directive and the
Dockerfile installation setup.
Bumps the k8s group with 2 updates in the / directory: k8s.io/apimachinery and k8s.io/kubectl.
Updates
k8s.io/apimachineryfrom 0.35.4 to 0.36.2Commits
ae3f98eUpdate dependencies to v0.36.2 tag2ec982dMerge pull request #139508lalitc375/automated-cherry-pick-of-#1394806a88102Fix wrong marking of errorsefb7f26Merge remote-tracking branch 'origin/master' into release-1.36d966e56Update github.com/moby/spdystream from v0.5.0 to v0.5.179b3632Merge pull request #137864 from yongruilin/dv-dra-mismatcha8822f7Add slice and map union member support with tests7dba2d0Use IsZero instead of IsNil for union ratcheting checkd95710fFix union validation ratcheting when oldObj is nil729062dMerge pull request #137849 from bryantbiggs/deps/update-kube-openapiUpdates
k8s.io/kubectlfrom 0.35.0 to 0.36.2Commits
7f7757aUpdate dependencies to v0.36.2 tag2a397b1Merge pull request #138500soltysh/automated-cherry-pick-of-#1384998598401Escape path inside the container50e8956Merge remote-tracking branch 'origin/master' into release-1.363f435caMerge pull request #138346 from dashpole/update_otel_prop36707c8Merge remote-tracking branch 'origin/master' into release-1.365e5dfaaUpdate github.com/moby/spdystream from v0.5.0 to v0.5.1777119fupdate go.opentelemetry.io/otel to v1.41.002b6975pause: fix version drift in various files82a3c05Merge pull request #137906 from aramase/aramase/c/grpc_v1.79.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by CodeRabbit