-
Notifications
You must be signed in to change notification settings - Fork 42
OPRUN-4439: Fix test operator controller pod probes #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@perdasilva: This pull request references OPRUN-4439 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
70de21f to
1316431
Compare
|
/jira refresh |
|
@perdasilva: This pull request references OPRUN-4439 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
4.22.0 is not an option in the target version field in Jira for me =/ |
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // Using the shell image provided by origin as the controller image. | ||
| // The image is mirrored into disconnected environments for testing. | ||
| "{{ TEST-CONTROLLER }}": image.ShellImage(), | ||
| "{{ TEST-CONTROLLER }}": "registry.k8s.io/e2e-test-images/busybox:1.36.1-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perdasilva it seems the cases in this g.Describe will run in disc env because there is no [Skipped:Disconnected] in case title.
if you change it, I am not sure if it still support disc env. so, I suggest
1, change it to https://github.com/openshift/origin/blob/main/test/extended/util/image/image.go#L54 for trying.
2, please take prow job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6 to run this case in this PR
if it pass, it is ok. or else, it will cause component readiness red.
if it does not pass with above suggestion, I am sorry I have no idea except for adding [Skipped:Disconnected] back for this case.
The test operator deployment is not reaching availability because the pod liveliness, readiness, and started probes are misconfigured and the httpd is getting a permission denied against /var/www.
This PR: