[release-4.21] NO-JIRA: rhaos-pkgs-match-openshift: exclude known package mismatches#1889
[release-4.21] NO-JIRA: rhaos-pkgs-match-openshift: exclude known package mismatches#1889marmijo wants to merge 1 commit intoopenshift:release-4.21from
Conversation
Introduce `RHAOS_PACKAGE_EXCEPTIONS` and build a regex from it to filter out packages that are known to not match the target version of openshift. Use a list-based structure so additional packages can be excluded in the future by appending to the exception array. Exclude the toolbox and conmon rhaos packages, which are not expected to match. Also remove the rhaos-pkgs-match-openshift test from the denylist. See: openshift#1847
|
@marmijo: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@marmijo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think this one is ready now that the one for master got merged? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marmijo, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introduce
RHAOS_PACKAGE_EXCEPTIONSand build a regex from it to filter out packages that are known to not match the target version of openshift. Use a list-based structure so additional packages can be excluded in the future by appending to the exception array.Exclude the toolbox and conmon rhaos packages, which are not expected to match.
Also remove the
rhaos-pkgs-match-openshifttest from the denylist.See: #1847