Skip to content

[DNM] [WIP] Remove DeepCopy from Node Controller reconcile.#3106

Draft
marty-power wants to merge 1 commit intoopenshift:masterfrom
marty-power:remove-deep-copy
Draft

[DNM] [WIP] Remove DeepCopy from Node Controller reconcile.#3106
marty-power wants to merge 1 commit intoopenshift:masterfrom
marty-power:remove-deep-copy

Conversation

@marty-power
Copy link
Copy Markdown
Contributor

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

Signed-off-by: Marty Power <mapower@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 1, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4ba71791-dc01-4248-ba7f-6a0249b0c186

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marty-power
Once this PR has been reviewed and has the lgtm label, please assign martinkennelly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marty-power
Copy link
Copy Markdown
Contributor Author

/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 2, 2026

@marty-power: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw d535539 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/security d535539 link false /test security
ci/prow/e2e-gcp-ovn-techpreview d535539 link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-aws-ovn-edge-zones d535539 link true /test e2e-aws-ovn-edge-zones
ci/prow/4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade d535539 link true /test 4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn d535539 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-local-gateway d535539 link true /test e2e-aws-ovn-local-gateway
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp d535539 link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/e2e-aws-ovn-rhcos10-techpreview d535539 link false /test e2e-aws-ovn-rhcos10-techpreview
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration d535539 link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-metal-ipi-ovn-ipv6 d535539 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant