Skip to content

[DNM] [WIP] Test: Filter AddrList Using Strict Checks#3110

Draft
marty-power wants to merge 3 commits intoopenshift:masterfrom
marty-power:addrlist-filter
Draft

[DNM] [WIP] Test: Filter AddrList Using Strict Checks#3110
marty-power wants to merge 3 commits intoopenshift:masterfrom
marty-power:addrlist-filter

Conversation

@marty-power
Copy link
Copy Markdown
Contributor

@marty-power marty-power commented Apr 2, 2026

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

kyrtapz added 3 commits April 2, 2026 13:40
@kyrtapz @marty-power
Stop using netlink.AddrList directly
475925c 
Signed-off-by: Patryk Diak <pdiak@redhat.com>
@kyrtapz @marty-power
Bump vishvananda/netlink
e6e11f2 
Bump github.com/vishvananda/netlink to consume
vishvananda/netlink@72a8cd7

Signed-off-by: Patryk Diak <pdiak@redhat.com>
@kyrtapz @marty-power
Use netlink handle with strict check for AdrrList
28baab1 
Strict check enables kernel-side filtering for netlink dump requests.

Signed-off-by: Patryk Diak <pdiak@redhat.com>

# Conflicts:
#	go-controller/pkg/util/net_linux.go
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: f83c9dd3-1045-4eca-8e98-7d65e076b8fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marty-power
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marty-power
Copy link
Copy Markdown
Contributor Author

marty-power commented Apr 3, 2026

/test all

@marty-power
Copy link
Copy Markdown
Contributor Author

marty-power commented Apr 6, 2026

/test qe-perfscale-aws-ovn-small-udn-density-l3

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 6, 2026

@marty-power: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift 28baab1 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-upgrade 28baab1 link true /test e2e-aws-ovn-upgrade
ci/prow/4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade-ipsec 28baab1 link false /test 4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade-ipsec
ci/prow/e2e-metal-ipi-ovn-dualstack 28baab1 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/images 28baab1 link true /test images
ci/prow/4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade 28baab1 link true /test 4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn 28baab1 link true /test e2e-aws-ovn
ci/prow/4.22-upgrade-from-stable-4.21-images 28baab1 link true /test 4.22-upgrade-from-stable-4.21-images
ci/prow/e2e-aws-ovn-local-gateway 28baab1 link true /test e2e-aws-ovn-local-gateway
ci/prow/e2e-gcp-ovn-techpreview 28baab1 link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-azure-ovn-upgrade 28baab1 link true /test e2e-azure-ovn-upgrade
ci/prow/okd-scos-images 28baab1 link true /test okd-scos-images
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 28baab1 link true /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-metal-ipi-ovn-ipv6 28baab1 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade 28baab1 link true /test 4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp 28baab1 link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw 28baab1 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/qe-perfscale-aws-ovn-small-udn-density-l2 28baab1 link false /test qe-perfscale-aws-ovn-small-udn-density-l2
ci/prow/e2e-gcp-ovn 28baab1 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 28baab1 link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/qe-perfscale-payload-control-plane-6nodes 28baab1 link true /test qe-perfscale-payload-control-plane-6nodes
ci/prow/e2e-aws-ovn-edge-zones 28baab1 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-fdp-qe 28baab1 link true /test e2e-aws-ovn-fdp-qe
ci/prow/e2e-aws-ovn-upgrade-local-gateway 28baab1 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/security 28baab1 link false /test security
ci/prow/e2e-aws-ovn-windows 28baab1 link true /test e2e-aws-ovn-windows
ci/prow/e2e-aws-ovn-rhcos10-techpreview 28baab1 link false /test e2e-aws-ovn-rhcos10-techpreview
ci/prow/e2e-aws-ovn-serial 28baab1 link true /test e2e-aws-ovn-serial
ci/prow/qe-perfscale-aws-ovn-small-udn-density-l3 28baab1 link false /test qe-perfscale-aws-ovn-small-udn-density-l3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marty-power @kyrtapz