Skip to content

NO-JIRA: Branch Sync release-4.20 to release-4.19 [04-15-2026]#3138

Open
openshift-pr-manager[bot] wants to merge 3 commits intorelease-4.19from
sync-release-4.20-to-release-4.19-04-15-2026
Open

NO-JIRA: Branch Sync release-4.20 to release-4.19 [04-15-2026]#3138
openshift-pr-manager[bot] wants to merge 3 commits intorelease-4.19from
sync-release-4.20-to-release-4.19-04-15-2026

Conversation

@openshift-pr-manager
Copy link
Copy Markdown

@openshift-pr-manager openshift-pr-manager Bot commented Apr 15, 2026

Automated branch sync: release-4.20 to release-4.19.

pliurh and others added 3 commits March 31, 2026 16:31
@pliurh
node: fix serviceUpdateNotNeeded nil pointer comparison
2a5bf31 
serviceUpdateNotNeeded() used explicit nil guards before dereferencing
InternalTrafficPolicy and AllocateLoadBalancerNodePorts. When both old
and new are nil (all non-LoadBalancer services), (nil != nil && ...)
evaluates to false, incorrectly indicating an update is needed.

Use reflect.DeepEqual on the pointer directly, which handles nil == nil.

Signed-off-by: Peng Liu <pliu@redhat.com>
(cherry picked from commit 40caf4c)
(cherry picked from commit 581bfde)
@openshift-merge-bot
Merge pull request #3099 from pliurh/release-4.20
b8b321e 
[release-4.20] OCPBUGS-81477: node: fix serviceUpdateNotNeeded nil pointer comparison
Merge remote-tracking branch 'origin/release-4.20' into sync-release-…
ecca60e 
…4.20-to-release-4.19-04-15-2026
@openshift-pr-manager
Copy link
Copy Markdown
Author

openshift-pr-manager Bot commented Apr 15, 2026

/ok-to-test
/payload 4.19 ci blocking
/payload 4.19 nightly blocking

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 15, 2026

@openshift-pr-manager[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

Automated branch sync: release-4.20 to release-4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

@openshift-pr-manager[bot]: trigger 5 job(s) of type blocking for the ci release of OCP 4.19

  • periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.19-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a30ca760-38a9-11f1-82c1-a391d8375907-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-main-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-main-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-main-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-main-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a30ca760-38a9-11f1-82c1-a391d8375907-1

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-pr-manager[bot]
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 15, 2026

@openshift-pr-manager[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift ecca60e link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-azure-ovn-upgrade ecca60e link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-fdp-qe ecca60e link true /test e2e-aws-ovn-fdp-qe
ci/prow/security ecca60e link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jluhrsen
Copy link
Copy Markdown
Contributor

jluhrsen commented Apr 23, 2026

/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift
/test e2e-azure-ovn-upgrade

@jluhrsen
Copy link
Copy Markdown
Contributor

jluhrsen commented Apr 23, 2026

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
/payload-job periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
/payload-job periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

@jluhrsen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aks
  • periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.19-upgrade-from-stable-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ba0fca10-3eac-11f1-8ee6-d14e0a5ee80d-0

@jluhrsen
Copy link
Copy Markdown
Contributor

jluhrsen commented Apr 23, 2026

/hold
This PR only has one commit and it is a dup of this that already exists in 4.19

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaamano jcaamano Awaiting requested review from jcaamano

@martinkennelly martinkennelly Awaiting requested review from martinkennelly

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-ci-robot @jluhrsen @pliurh