installer: Skip OpenStack jobs when only docs are changed #72296
Conversation
|
@eshulman2, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/assign stephenfin |
eshulman2
force-pushed
the
openstack-skip-docs
branch
from
3c380f6 to
b8e4c53
Compare
openshift-merge-robot
added
the
needs-rebase
openshift-ci-robot
added
the
rehearsals-ack
eshulman2
force-pushed
the
openstack-skip-docs
branch
from
a76ad18 to
ff28d5f
Compare
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eshulman2 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
removed
the
rehearsals-ack
eshulman2
force-pushed
the
openstack-skip-docs
branch
from
ff28d5f to
4567435
Compare
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
IMO, this brings significant risk of jobs not running when they should and I'm not convinced it's worth the risk. There are only a few docs files that have openstack in their path, and they don't change that often.
ci-operator/config/openshift/installer/openshift-installer-main.yaml
Outdated
Show resolved
Hide resolved
| workflow: baremetalds-e2e-virtualmedia | ||
| - as: e2e-openstack-ovn | ||
| run_if_changed: openstack|(^data/.*/rhcos\.json) | ||
| run_if_changed: (^(pkg|data|images|upi|cluster-api|vendor)/.*openstack)|(^data/.*/rhcos\.json) |
There was a problem hiding this comment.
I understand the intent, but aren't we at risk of NOT running the CI on important changes if the structure of the installer changes?
There was a problem hiding this comment.
I agree this is a risk we need to be aware of. IMO this is a risk we need to decide if we want to take. I would assume a major structure change would lead to re-working some of the CI in any case but I agree this is something we need to take into account when considering the pros and cons of this change.
There was a problem hiding this comment.
I'm leaning towards rejecting the change because the gain is minimal, for the rare changes to openstack docs, and introduces a risk of missing CI feedback on important changes. I'll let @stephenfin weight in.
Add skip_if_only_changed pattern to OpenStack e2e jobs to prevent unnecessary job execution when only documentation files are modified. This affects e2e-openstack-ovn, e2e-openstack-proxy, e2e-openstack-nfv-intel, and openstack-manifests jobs across all active release branches (4.12-4.22 and main). Also remove docs/user/openstack/install_upi.md from run_if_changed patterns in e2e-openstack-dualstack-upi jobs to avoid conflicts with the skip_if_only_changed filter. assited-by claude
eshulman2
force-pushed
the
openstack-skip-docs
branch
from
4567435 to
540138c
Compare
|
[REHEARSALNOTIFIER]
A total of 41 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@eshulman2: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I'd also mention that the UPI docs contain code that is tested in the CI. The UPI CI job literally executes the UPI documentation. |
Yes I discussed it with @mandre on slack and changed it back |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
6 participants
Add skip_if_only_changed pattern to OpenStack e2e jobs to prevent unnecessary job execution when only documentation files are modified. This affects e2e-openstack-ovn, e2e-openstack-proxy, e2e-openstack-nfv-intel, and openstack-manifests jobs across all active release branches (4.12-4.22 and main).
Also remove docs/user/openstack/install_upi.md from run_if_changed patterns in e2e-openstack-dualstack-upi jobs to avoid conflicts with the skip_if_only_changed filter.
assited-by claude