Add Platform:metal variant for agent baremetal jobs#3734
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Agent baremetal jobs using iso-no-registry deploy on bare metal but don't have -metal in their name, so they were missing the Platform:metal variant. Add a narrower pattern match for -iso-no-registry before the generic -metal pattern. This is a more targeted fix than matching all -e2e-agent- jobs, which would incorrectly reclassify agent jobs running on other platforms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bb54308 to
186bb6f
Compare
|
/lgtm |
|
/approve |
|
Scheduling required tests: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, redhat-chai-bot, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Agent baremetal jobs (e.g.
e2e-agent-compact-*,e2e-agent-ha-dualstack-*,e2e-agent-sno-*) deploy on bare metal but don't have-metalin their job names. This causessetPlatform()in the variant registry to skip them entirely, leaving them with no Platform variant dimension in BigQuery'sjob_variantstable.This blocks the new
Installer / Agent based installationcomponent from appearing in Component Readiness — because CR filters on Platform via an intersect query, jobs without any Platform row are invisible regardless of which Platform filter value you select.Changes
{"-e2e-agent-", "metal"}pattern tosetPlatform()inpkg/variantregistry/ocp.go, placed above the generic{"-metal", "metal"}entry (first-match-wins semantics)pkg/variantregistry/snapshot.yamlviamake update-variantsImpact
106 agent jobs across all tracked releases now gain
Platform:metal. No other variant dimensions are affected.Context
Discussion thread: https://redhat-internal.slack.com/archives/C01CQA76KMX (forum-ocp-release-oversight)