Skip to content

Add Platform:metal variant for agent baremetal jobs#3734

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:agent-platform-metal-variant
Jul 6, 2026
Merged

Add Platform:metal variant for agent baremetal jobs#3734
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:agent-platform-metal-variant

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Agent baremetal jobs (e.g. e2e-agent-compact-*, e2e-agent-ha-dualstack-*, e2e-agent-sno-*) deploy on bare metal but don't have -metal in their job names. This causes setPlatform() in the variant registry to skip them entirely, leaving them with no Platform variant dimension in BigQuery's job_variants table.

This blocks the new Installer / Agent based installation component from appearing in Component Readiness — because CR filters on Platform via an intersect query, jobs without any Platform row are invisible regardless of which Platform filter value you select.

Changes

  • Added {"-e2e-agent-", "metal"} pattern to setPlatform() in pkg/variantregistry/ocp.go, placed above the generic {"-metal", "metal"} entry (first-match-wins semantics)
  • Regenerated pkg/variantregistry/snapshot.yaml via make update-variants

Impact

106 agent jobs across all tracked releases now gain Platform:metal. No other variant dimensions are affected.

Context

Discussion thread: https://redhat-internal.slack.com/archives/C01CQA76KMX (forum-ocp-release-oversight)

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@redhat-chai-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6553f344-6746-4652-bc40-4fa0c4e26f3e

📥 Commits

Reviewing files that changed from the base of the PR and between 6ab2e82 and 186bb6f.

📒 Files selected for processing (2)
  • pkg/variantregistry/ocp.go
  • pkg/variantregistry/snapshot.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jul 6, 2026
@openshift-ci openshift-ci Bot requested review from deepsm007 and petr-muller July 6, 2026 14:21
Agent baremetal jobs using iso-no-registry deploy on bare metal but
don't have -metal in their name, so they were missing the Platform:metal
variant. Add a narrower pattern match for -iso-no-registry before the
generic -metal pattern.

This is a more targeted fix than matching all -e2e-agent- jobs, which
would incorrectly reclassify agent jobs running on other platforms.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@redhat-chai-bot redhat-chai-bot force-pushed the agent-platform-metal-variant branch from bb54308 to 186bb6f Compare July 6, 2026 14:33
@andfasano

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2026
@stbenjam

stbenjam commented Jul 6, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@stbenjam

stbenjam commented Jul 6, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, redhat-chai-bot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 70e48f5 into openshift:main Jul 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants