forked from velero-io/velero
-
Notifications
You must be signed in to change notification settings - Fork 20
Merge https://github.com/velero-io/velero:main (e6d928c) into oadp-dev #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oadp-rebasebot-app
wants to merge
119
commits into
openshift:oadp-dev
Choose a base branch
from
oadp-rebasebot:rebase-bot-oadp-dev
base: oadp-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
119 commits
Select commit
Hold shift + click to select a range
7f51017
block data mover design
Lyndon-Li 4ada356
Merge branch 'main' into block-data-mover-design
Lyndon-Li a230929
block data mover design
Lyndon-Li 81029d6
irregular volume size
Lyndon-Li 1c9c669
Add e2e test case for PR 9452
206219d
Add e2e test case for issue 7725
89ead22
Merge branch 'main' into add-e2e-tests-for-PR9452
hollycai05 2bf93ff
Merge branch 'main' into add-e2e-tests-for-issue7725
Lyndon-Li dd82645
Fix PodVolumeBackup list scope during restore
adam-jian-zhang 1b5503e
Bump external-snapshotter to v8.4.0 for VGS v1beta2 support
shubham-pampattiwar 0cf8f94
Add changelog for PR #9695
shubham-pampattiwar 37abfb4
Merge pull request #9682 from adam-jian-zhang/fix-restore-pvr-scope
Lyndon-Li 1730b7f
issue 9428: incremental repo maintenance history queue length
Lyndon-Li e1cc07c
Merge pull request #9695 from shubham-pampattiwar/bump-ext-snapshotte…
blackpiglet 4a6756d
Merge pull request #9683 from Lyndon-Li/increase-repo-maintenance-his…
Lyndon-Li 7562011
Fix DataUpload list scope in CSI PVC backup plugin
adam-jian-zhang eaef4ea
Merge pull request #9704 from adam-jian-zhang/fix-csi-pvc-backup-plug…
Lyndon-Li eb0a181
chore: update base image to newer debian image
emirot cd89c0f
chore: update base image to newer debian image
emirot 97ffb9e
add cbt interfaces
Lyndon-Li cf605c9
Add CI check for invalid characters in file paths (#9553)
kaovilai e855eae
Merge branch 'main' into cbt-interfaces
Lyndon-Li e921c17
Merge pull request #9701 from emirot/chore/update_base_image
blackpiglet 5b9bcc9
block data mover design
Lyndon-Li 1b4c7fe
fix change log path error for 9683
Lyndon-Li 15db9d2
Merge pull request #9721 from Lyndon-Li/fix-change-log-path-error
Lyndon-Li a990bd8
Merge branch 'main' into block-data-mover-design
Lyndon-Li 87b5445
Merge branch 'main' into cbt-interfaces
Lyndon-Li 8a6ac7a
fix: backup deletion silently succeeds when tarball download fails (#…
priyansh17 df2686c
Add delay to avoid race conditions during VolumeSnapshotContent delet…
priyansh17 c5fa50b
Merge pull request #9528 from Lyndon-Li/block-data-mover-design
blackpiglet 4d9bd91
Update the "community" page of website (#9722)
reasonerjt 39db9f9
Remove Restic build from Dockerfile, Makefile and Tiltfile.
blackpiglet fc6361b
perf: better string concatenation (#9705)
emirot 455f3ba
unified repo interface extension for block data mover
Lyndon-Li 71b230f
Merge pull request #9728 from blackpiglet/9490_fix
Lyndon-Li 8e9e6b4
added parallel backup configuration to install docs (#9729)
sseago a75775e
Merge pull request #9724 from Lyndon-Li/unified-repo-interface-extension
ywk253100 2ca4e46
add cbt interfaces
Lyndon-Li 256e106
Merge branch 'main' into cbt-interfaces
Lyndon-Li 1160ae2
Merge pull request #9716 from Lyndon-Li/cbt-interfaces
Lyndon-Li a96a73d
Set permissions to the actions
reasonerjt 2d6865d
Merge pull request #9739 from reasonerjt/update-actions-permissions
Lyndon-Li da3e7cf
Remove Restic code path from PodVolumeRestore.
blackpiglet 0fa1910
fix: honor -stderrthreshold when -logtostderr is true (default)
pierluigilenoci 4d23571
fix: add changelog and nolint explanation for CI
pierluigilenoci 3b34fb8
Fix wildcard expansion when includes is empty and excludes has wildca…
Joeavaikath 7549408
update hashicorp/go-hclog and go-plugin to current version (#9613)
pjjw f30be4b
Merge pull request #9654 from pierluigilenoci/fix/honor-stderrthreshold
blackpiglet 6090392
Merge pull request #9732 from blackpiglet/9468_fix
blackpiglet f494e10
Bump go.opentelemetry.io/otel from 1.40.0 to 1.41.0
dependabot[bot] 2b1fa4f
Merge pull request #9751 from velero-io/dependabot/go_modules/go.open…
Lyndon-Li b3c178b
Fix error in auto-request-review action
reasonerjt 065926d
Merge pull request #9753 from reasonerjt/fix-auto-request-review-error
Lyndon-Li 16ca773
add concurrency limit to go-releaser
Lyndon-Li f67ba0e
Merge pull request #9757 from Lyndon-Li/add-go-releaser-concurrency-l…
reasonerjt 36dde0f
fix go-releaser upload error
Lyndon-Li b635035
Merge branch 'main' into fix-go-releaser-upload-issue
Lyndon-Li 3f0c221
Merge pull request #9759 from Lyndon-Li/fix-go-releaser-upload-issue
Lyndon-Li 79faa5f
Bump go.opentelemetry.io/otel/sdk from 1.40.0 to 1.43.0 (#9692)
dependabot[bot] ca41757
Merge pull request #9567 from hollycai05/add-e2e-tests-for-issue7725
reasonerjt 1056305
Merge pull request #9565 from hollycai05/add-e2e-tests-for-PR9452
reasonerjt 76197d7
fix: lint permission issue (#9740)
emirot f72c57b
Bump github.com/moby/spdystream from 0.5.0 to 0.5.1 (#9734)
dependabot[bot] 7918cb3
fix docker hub push error
Lyndon-Li 7aab742
Merge pull request #9763 from Lyndon-Li/fix-docker-hub-push-error
Lyndon-Li 360095a
Merge pull request #9558 from Joeavaikath/wildcard-ns-bugfix
Joeavaikath e6d928c
Some updates for actions on main branch. (#9775)
blackpiglet f0c7bcc
merge upstream/main into oadp-dev
oadp-maintainers 878091d
skip subresource in resource discovery (#6688)
reasonerjt 8450d94
fix issue 6753
Lyndon-Li 9349ce9
Update restore controller logic for restore deletion (#6761)
ywk253100 2570fb1
Fix #6752: add namespace exclude check.
85f2ac2
add csi snapshot data movement doc
Lyndon-Li 69ce3cd
Modify changelogs for v1.12
allenxu404 075149e
issue 6786:always delete VSC regardless of the deletion policy
Lyndon-Li 2817a34
issue: move plugin depdending podvolume functions to util pkg
Lyndon-Li e8c8787
issue 6880: set ParallelUploadAboveSize as MaxInt64
Lyndon-Li aaa3a5a
changelog
kaovilai 81c151a
Add support for block volumes (#6680) (#6897)
dzaninovic c0444df
Replace the base image with paketobuildpacks image
ywk253100 6e1a61d
issue 6734: spread backup pod evenly
Lyndon-Li 40a75b2
Add doc links for new features to release note
allenxu404 e8b36b7
fix issue 6647
Lyndon-Li 6f8ad04
Perf improvements for existing resource restore
sseago c7913bb
issue #6807: Retry failed create when using generateName
sseago 45d5a40
Import auth provider plugins
0x113 c3b9fa6
Add v1.12.1 changelog
allenxu404 a1bc9eb
Make Windows build skip BlockMode code.
e4167d8
udmrepo use region specified in BSL when s3URL is empty
Lyndon-Li 83edcf3
Change v1.12.1 changelog
allenxu404 e3705a6
Dockerfile.ubi/travis local files
dymurray b353f4e
Add BZ + Publish automation to repo (#82)
rayfordj 6c07e14
remove dependabot config from fork
sseago 9c37068
Create Makefile.prow
kaovilai e3b1a8a
set HOME in velero image for kopia, update controller-gen for CI (#280)
sseago 0e91029
build velero-helper binary for datamover pod
sseago 35a79ef
restore: Use warning when Create IsAlreadyExist and Get error
kaovilai d8fd988
kopia/repository/config/aws.go: Set session.Options profile from config
kaovilai 96f14ba
use ubi9-latest to build
sseago 3e97737
OADP-4225: add tzdata to Dockerfile.ubi
sseago 0c50c4c
fix: CI (#316)
0f79b10
fix: ARM images (#332)
95d19a4
ubi: BUILDPLATFORM to build stage to enable cross compile. (#336)
kaovilai b28fa42
OADP-4640: Downstream only to allow override kopia default algorithms…
mpryc 1f22559
Downstream only: Rework of Makefile and incusion of lint
mpryc 8c22ea6
Downstream only - fix lint error in downtream change (#343)
mpryc 0b3787e
run oadp-operator e2e test from the velero repo (#353)
weshayutin b2235e2
DS Owners
kaovilai 8cf74a7
updated controller-gen version
sseago 99e85cd
Include velero-restore-helper binary in velero image (#374)
sseago b3c86e8
Fix restic checkout in Dockerfile.ubi to get default branch (#436)
sseago 7ff6ce3
UPSTREAM: <drop>: Updating go modules
oadp-maintainers 41d8a68
UPSTREAM: <drop>: update restic @ 8c4c3fbfe (branch oadp-dev)
oadp-maintainers a1b5ec7
UPSTREAM: <carry> Use context from test for the kopia algorithms
oadp-maintainers f872f0f
UPSTREAM: <drop>: Updating go modules
oadp-maintainers 6158c20
UPSTREAM: <carry>: Fix golangci-lint configuration for v2.x
mpryc 484c172
add konfluxdockerfile for future
weshayutin 3aba53f
UPSTREAM: <drop>: Updating go modules
oadp-maintainers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| name: Pull Request File Path Check | ||
| on: [pull_request] | ||
| jobs: | ||
|
|
||
| filepath-check: | ||
| name: Check for invalid characters in file paths | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
| - name: Check out the code | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Validate file paths for Go module compatibility | ||
| run: | | ||
| # Go's module zip rejects filenames containing certain characters. | ||
| # See golang.org/x/mod/module fileNameOK() for the full specification. | ||
| # | ||
| # Allowed ASCII: letters, digits, and: !#$%&()+,-.=@[]^_{}~ and space | ||
| # Allowed non-ASCII: unicode letters only | ||
| # Rejected: " ' * < > ? ` | / \ : and any non-letter unicode (control | ||
| # chars, format chars like U+200E LEFT-TO-RIGHT MARK, etc.) | ||
| # | ||
| # This check catches issues like the U+200E incident in PR #9552. | ||
|
|
||
| EXIT_STATUS=0 | ||
|
|
||
| git ls-files -z | python3 -c " | ||
| import sys, unicodedata | ||
|
|
||
| data = sys.stdin.buffer.read() | ||
| files = data.split(b'\x00') | ||
|
|
||
| # Characters explicitly rejected by Go's fileNameOK | ||
| # (path separators / and \ are inherent to paths so we check per-element) | ||
| bad_ascii = set('\"' + \"'\" + '*<>?\`|:') | ||
|
|
||
| allowed_ascii = set('!#$%&()+,-.=@[]^_{}~ ') | ||
|
|
||
| def is_ok(ch): | ||
| if ch.isascii(): | ||
| return ch.isalnum() or ch in allowed_ascii | ||
| return ch.isalpha() | ||
|
|
||
| bad_files = [] # list of (original_path, clean_path, char_desc) | ||
| for f in files: | ||
| if not f: | ||
| continue | ||
| try: | ||
| name = f.decode('utf-8') | ||
| except UnicodeDecodeError: | ||
| print(f'::error::Non-UTF-8 bytes in filename: {f!r}') | ||
| bad_files.append((repr(f), None, 'non-UTF-8 bytes')) | ||
| continue | ||
|
|
||
| # Check each path element (split on /) | ||
| for element in name.split('/'): | ||
| for ch in element: | ||
| if not is_ok(ch): | ||
| cp = ord(ch) | ||
| char_name = unicodedata.name(ch, f'U+{cp:04X}') | ||
| char_desc = f'U+{cp:04X} ({char_name})' | ||
| # Build cleaned path by stripping invalid chars | ||
| clean = '/'.join( | ||
| ''.join(c for c in elem if is_ok(c)) | ||
| for elem in name.split('/') | ||
| ) | ||
| print(f'::error file={name}::File \"{name}\" contains invalid char {char_desc}') | ||
| bad_files.append((name, clean, char_desc)) | ||
| break | ||
|
|
||
| if bad_files: | ||
| print() | ||
| print('The following files have characters that are invalid in Go module zip archives:') | ||
| print() | ||
| for original, clean, desc in bad_files: | ||
| print(f' {original} — {desc}') | ||
| print() | ||
| print('To fix, rename the files to remove the problematic characters:') | ||
| print() | ||
| for original, clean, desc in bad_files: | ||
| if clean: | ||
| print(f' mv \"{original}\" \"{clean}\" && git add \"{clean}\"') | ||
| print(f' # or: git mv \"{original}\" \"{clean}\"') | ||
| else: | ||
| print(f' # {original} — cannot auto-suggest rename (non-UTF-8)') | ||
| print() | ||
| print('See https://github.com/velero-io/velero/pull/9552 for context.') | ||
| sys.exit(1) | ||
| else: | ||
| print('All file paths are valid for Go module zip.') | ||
| " || EXIT_STATUS=1 | ||
|
|
||
| exit $EXIT_STATUS | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add block data mover design for block level incremental backup by integrating with Kubernetes CBT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Wildcard namespaces: Log warning on empty resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| update go-hclog to current version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9658, Honor --stderrthreshold when --logtostderr is enabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9681, fix restores and podvolumerestores list options to only list in installed namespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9428, increase repo maintenance history queue length from 3 to 25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix wildcard expansion when includes is empty and excludes has wildcards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Enhance backup deletion logic to handle tarball download failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Bump external-snapshotter to v8.4.0 and migrate VolumeGroupSnapshot API from v1beta1 to v1beta2 for Kubernetes 1.34+ compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9699, add a 2-second gap between temporary CSI VolumeSnapshotContent create and delete operations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Update Debian base image from bookworm to trixie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9703, fix CSI PVC Backup Plugin list options to only list in installed namespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| perf: better string concatenation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9709, add interfaces for CBT service and CBT bitmap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix issue #9723, extend Unified Repo Interface to support block uploader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Remove Restic build from Dockerfile, Makefile and Tiltfile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Remove Restic code path from PodVolumeRestore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| fix: lint permission issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop scanning a file after the first invalid character report.
At Line 69,
breakexits only the inner loop. The same file can be appended multiple times (one per invalid path element), producing duplicate error and rename lines.Suggested change
🤖 Prompt for AI Agents