Skip to content

Fix pre-existing bugs: stale closures, double-fire, zoom edge cases #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasttvo merged 60 commits into from
Apr 29, 2026
Merged

Fix pre-existing bugs: stale closures, double-fire, zoom edge cases #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
b5f576e
sort
Dec 15, 2025
e105c42
RN79
Dec 20, 2025
963d935
fix scale
Dec 20, 2025
b8d1854
remove jest since there's no tests
Dec 20, 2025
c674720
strip
Dec 20, 2025
8882bae
Merge remote-tracking branch 'origin/master' into thomas/import-sort
Dec 24, 2025
e872f01
Merge branch 'thomas/import-sort' into thomas/RN79
Dec 24, 2025
0b2b720
Merge remote-tracking branch 'origin/master' into thomas/RN79
Dec 24, 2025
9165d4d
Merge branch 'thomas/RN79' into thomas/strip-features
Dec 24, 2025
d9e7eff
removed type
Dec 29, 2025
9458013
removed type
Dec 29, 2025
adbb19a
Fix review findings: stopAnimation callback, listener cleanup, docs, …
Apr 13, 2026
76025b3
Fix zoomTo() listener leak and stop in-flight animations on unmount
Apr 13, 2026
538f638
Merge remote-tracking branch 'origin/master' into thomas/strip-features
Apr 13, 2026
db946be
Strip lib/ build artifacts made redundant by #158
Apr 13, 2026
f095c20
Fix incomplete componentWillUnmount teardown
Apr 13, 2026
06f4c4e
Fix README: correct pinchToZoomInSensitivity default from 3 to 1
Apr 13, 2026
aa34667
fix: prevent zoomAnim listener leak on rapid zoomTo calls
Apr 13, 2026
4529a35
Fix zoom listener cleanup and docs
Apr 14, 2026
0c9d583
Fix unmount and static pin gesture cleanup
Apr 14, 2026
7d610d1
fix: handle StaticPin responder termination
Apr 15, 2026
a8af161
fix: track StaticPin parent handoff
Apr 15, 2026
222f80e
fix: preserve terminate callback for StaticPin
Apr 15, 2026
c85e6ce
fix: harden StaticPin gesture handoff
Apr 15, 2026
f774bd7
fix: suppress StaticPin taps after drags
Apr 15, 2026
09f5a92
fix: address Claude review — phantom tap, stale closure, mounted guard
Apr 16, 2026
8b0fe3b
Add SPECS.md — comprehensive behavior contract for the library
Apr 16, 2026
6820856
Revert "Add SPECS.md — comprehensive behavior contract for the library"
Apr 16, 2026
99b5406
fix: mounted guard in measure callback, clear singleTapTimeout on gra…
Apr 16, 2026
02df387
fix: pre-existing bugs — stale closures, double-fire, zoom edge cases
Apr 16, 2026
6c2c98c
fix: guard onZoomAfter against interrupted/cancelled animations
Apr 16, 2026
a716099
fix: clear stale double-tap state on pan grant, fix README callback r…
Apr 16, 2026
2ccf914
Merge remote-tracking branch 'origin/thomas/pre-existing-fixes' into …
Apr 16, 2026
c8604f0
fix: add cycle-back for double-tap when maxZoom=null, fix zoomTo JSDoc
Apr 16, 2026
cf2d4d7
fix: only clear double-tap state on drag start, not on every touch
Apr 16, 2026
98d48a1
fix: maxZoom/minZoom type accepts null, guard zoomTo callback with mo…
Apr 16, 2026
cda405e
fix: clear double-tap state in longPress callback
Apr 16, 2026
5bed041
revert: remove post-merge commits to restore PR #149 scope
Apr 16, 2026
d21d8f8
fix: pre-existing bugs — stale closures, double-fire, zoom edge cases
Apr 16, 2026
e7d6b2a
fix: guard onZoomAfter against interrupted/cancelled animations
Apr 16, 2026
57575a4
fix: guard onZoomAfter against unmount, correct zoomTo JSDoc
Apr 16, 2026
eb8ca03
fix: restore double-tap cycle-back, flush pin debounce on zoomTo
Apr 16, 2026
61c3676
fix: flush debounce on single-tap pan, clarify zoom cycle-back
Apr 16, 2026
498ff31
refactor: remove dead _updateStaticPin, rename shadowed listenerId
Apr 16, 2026
3d49a85
Merge remote-tracking branch 'origin/master' into thomas/pre-existing…
Apr 19, 2026
e9615c0
Update SPECS for zoom and static pin fixes
Apr 19, 2026
84e9875
Fix moveTo and moveBy zoomTo cancellation
Apr 19, 2026
96dbac8
Merge origin/master into thomas/pre-existing-fixes-v2
Apr 29, 2026
07dff2c
Fix pinch-during-zoomTo race and remove redundant zoom write in pan o…
Apr 29, 2026
1be0936
Update SHARED_TASK_NOTES with cycle 1 no-op status
Apr 29, 2026
3a58463
Restore double-tap state cleanups dropped during functional conversion
Apr 29, 2026
ac70a41
Update SHARED_TASK_NOTES with cycle 3 no-op status
Apr 29, 2026
bbed882
Fix SPECS.md singleTapTimeoutId clearing enumeration
Apr 29, 2026
afae34a
Collapse unreachable C2 scenario in SPECS.md 3+-finger interruption
Apr 29, 2026
d3d7b6c
Fix stale-closure in publicZoomTo animation completion callback
Apr 29, 2026
4f75cec
Update SHARED_TASK_NOTES with cycle 7 no-op status
Apr 29, 2026
3dc7e53
Merge origin/master into thomas/pre-existing-fixes-v2
Apr 29, 2026
c2796dc
Update SHARED_TASK_NOTES with cycle 8 no-op status
Apr 29, 2026
3c5c929
Remove SHARED_TASK_NOTES.md from PR
Apr 29, 2026
5236919
Fix misplaced JSDoc above _cancelInFlightZoomToAnimation
Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading