Prevent unused slots in the recent preset list.

[Razen04]

Fixes #11405

Filtering before slicing prevents the unused slots in the recent preset list, more detail about this in #11405

If we wish to show the Motorway Link and others in the US and CA in the recent list, we can just prevent filtering the recent list based on location, I have already commented in the issue everything here.

[matkoniecz]

Can you add test so potential regression would be avoided?

[Razen04]

Sure, I will do it rn.

[Razen04]

It's really weird that Github gave attribute to some random account, I am trying to fix the commits because it contained my personal name which I don't wish to have. But Github attributed the commits to someone random person, I think I fixed it for now.

Anyways I have added the test case, never done before so maybe it is wrong do let me know that.

[matkoniecz]

when you select "motorway link" from major roads folder it will not appear in recent presets

yes, it is no longer blocking history slot but it is still a bug

[Razen04]

That is what's supposed to happen if we are in US or maybe CA too, OSM prevents those from appearing. I think it is intentionally done

[matkoniecz]

no, it is also clearly part of the same bug and unwanted behavior resulting from overcomplex area-specific presets

[Razen04]

Ohhh, I thought that was intentional, fine then I will just make it not check the location maybe and bypass that. But then why is the data containing that, as mentioned in the issue by me?

[matkoniecz]

randomly hiding motorway link from recently used entries is definitely not deliberate

it is side effect of having special motorway link entry for USA, maybe also other areas (which was well intentioned solution for some other problem but causing trouble due to increased complexity)