Skip to content

Sidebar auto-scroll when dragging relation members near top/bottom #11898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FaisalMisbah23 wants to merge 1 commit into
base: develop
Choose a base branch
from
+26 −1
Open

Sidebar auto-scroll when dragging relation members near top/bottom #11898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
##### 2026-03-02

#### :sparkles: Usability & Accessibility
* Sidebar auto-scrolls when dragging relation members near top or bottom edge (fixes [#11897], thanks [@FaisalMisbah23])
* Show warning when attempting to paste but nothing has been copied ([#9401], thanks [@omsaraykar])
* Don't suggest values from Taginfo for `addr:*` tags ([#11733], thanks [@k-yle])
* Don't suggest values from Taginfo for tags with less than 100 uses, even if they're documented on the wiki ([#11794], thanks [@Kaushik4141])
Expand Down Expand Up @@ -162,6 +163,8 @@ _Breaking developer changes, which may affect downstream projects or sites that
[be0a20e59]: https://github.com/openstreetmap/iD/commit/be0a20e59
[b06496780]: https://github.com/openstreetmap/iD/commit/b06496780
[#id-tagging-schema/pull/1507]: https://github.com/openstreetmap/id-tagging-schema/pull/1507
[#11897]: https://github.com/openstreetmap/iD/issues/11897
[@FaisalMisbah23]: https://github.com/FaisalMisbah23
[@ilias52730]: https://github.com/ilias52730
[@Razen04]: https://github.com/Razen04
[@homersimpsons]: https://github.com/homersimpsons
Expand Down
24 changes: 23 additions & 1 deletion modules/ui/sections/raw_member_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@ export function uiSectionRawMemberEditor(context) {
items.select('button.member-delete')
.on('click', deleteMember);

var dragOrigin, targetIndex;
var dragOrigin, targetIndex, scrollContainer;
var scrollEdgeThreshold = 40;
var scrollSpeed = 10;

items.call(d3_drag()
.on('start', function(d3_event) {
Expand All @@ -314,6 +316,7 @@ export function uiSectionRawMemberEditor(context) {
y: d3_event.y
};
targetIndex = null;
scrollContainer = selection.node().closest('.inspector-body');
})
.on('drag', function(d3_event) {
var x = d3_event.x - dragOrigin.x,
Expand All @@ -330,6 +333,23 @@ export function uiSectionRawMemberEditor(context) {

targetIndex = null;

// Auto-scroll sidebar when dragging near top or bottom edge (fixes #11897)
if (scrollContainer) {
var se = d3_event.sourceEvent;
var clientY = (se && (se.touches && se.touches[0] ? se.touches[0].clientY : se.clientY)) ?? d3_event.clientY;
if (typeof clientY === 'number') {
var rect = scrollContainer.getBoundingClientRect();
if (clientY - rect.top < scrollEdgeThreshold) {
scrollContainer.scrollTop = Math.max(0, scrollContainer.scrollTop - scrollSpeed);
} else if (rect.bottom - clientY < scrollEdgeThreshold) {
var maxScroll = scrollContainer.scrollHeight - scrollContainer.clientHeight;
if (maxScroll > 0) {
scrollContainer.scrollTop = Math.min(maxScroll, scrollContainer.scrollTop + scrollSpeed);
}
}
}
}

selection.selectAll('li.member-row')
.style('transform', function(d2, index2) {
var node = d3_select(this).node();
Expand All @@ -353,6 +373,8 @@ export function uiSectionRawMemberEditor(context) {

if (!d3_select(this).classed('dragging')) return;

scrollContainer = null;

var index = items.nodes().indexOf(this);

d3_select(this)
Expand Down