Skip to content

Fix zoom-to-data not re-fitting when custom data is already visible #11941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shyam-123pandey wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix zoom-to-data not re-fitting when custom data is already visible #11941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bd9562
Fix zoom-to-data not re-fitting when custom data is already visible
Shyam-123pandey Feb 28, 2026
ae67967
Fix zoom-to-data not re-fitting when custom data is already visible a…
Shyam-123pandey Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions modules/svg/data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { select as d3_select } from 'd3-selection';
import stringify from 'fast-json-stable-stringify';
import { gpx, kml } from '@tmcw/togeojson';

import { geoExtent, geoPolygonIntersectsPolygon } from '../geo';
import { geoExtent} from '../geo';
import { services } from '../services';
import { svgPath } from './helpers';
import { utilDetect } from '../util/detect';
Expand Down Expand Up @@ -513,7 +513,6 @@ export function svgData(projection, context, dispatch) {
if (!features.length) return;

var map = context.map();
var viewport = map.trimmedExtent().polygon();
var coords = features.reduce(function(coords, feature) {
var geom = feature.geometry;
if (!geom) return coords;
Expand All @@ -540,10 +539,8 @@ export function svgData(projection, context, dispatch) {
return utilArrayUnion(coords, c);
}, []);

if (!geoPolygonIntersectsPolygon(viewport, coords, true)) {
var extent = geoExtent(d3_geoBounds({ type: 'LineString', coordinates: coords }));
map.centerZoom(extent.center(), map.trimmedExtentZoom(extent));
}
var extent = geoExtent(d3_geoBounds({ type: 'LineString', coordinates: coords }));
map.centerZoom(extent.center(), map.trimmedExtentZoom(extent));

return this;
};
Expand Down
Loading