Skip to content

ref: simplify node occurrence check in validationImpossibleOneway #11943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dipanshurdev wants to merge 2 commits into
base: develop
Choose a base branch
from
+2 −8
Open

ref: simplify node occurrence check in validationImpossibleOneway #11943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e195080
refactor: simplify node occurrence check in validationImpossibleOneway
dipanshurdev Feb 28, 2026
c3c0cdd
refactor: enhance node occurrence check in validationImpossibleOneway
dipanshurdev Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions modules/validations/impossible_oneway.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,8 @@ export function validationImpossibleOneway() {
}

function nodeOccursMoreThanOnce(way, nodeID) {
let occurrences = 0;
for (const index in way.nodes) {
if (way.nodes[index] === nodeID) {
occurrences++;
if (occurrences > 1) return true;
}
}
return false;
const firstIndex = way.nodes.indexOf(nodeID);
return firstIndex !== -1 && firstIndex !== way.nodes.lastIndexOf(nodeID);
}

function isConnectedViaOtherTypes(way, node) {
Expand Down