Use primarily primary operation name in shortcut listing#11977
Merged
tyrasd merged 2 commits intoopenstreetmap:developfrom Mar 6, 2026
Merged
Use primarily primary operation name in shortcut listing#11977tyrasd merged 2 commits intoopenstreetmap:developfrom
tyrasd merged 2 commits intoopenstreetmap:developfrom
Conversation
tyrasd
approved these changes
Mar 6, 2026
tyrasd
approved these changes
Mar 6, 2026
Member
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
Thanks. I went even one step further: nowhere else in the UI we call the operation combine. The only benefit for including the "alternative" name of the operation would be to understand where the shortcut c is borrowed from (m was already taken by the move operation), but IMO that's not reason enough for the added complexity here.
Contributor
Author
|
Hmm, I disagree and I think it was worth it for mnemonic purposes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.