Skip to content

fix(ci): update nanotdf create function signature to use options #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sujankota wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): update nanotdf create function signature to use options #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions pkg/handlers/nano-tdf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,23 @@ package handlers
import (
"bytes"
"io"

"github.com/opentdf/platform/sdk"
)

func (h Handler) EncryptNanoBytes(b []byte, values []string, kasUrlPath string, ecdsaBinding bool) (*bytes.Buffer, error) {
var encrypted []byte
enc := bytes.NewBuffer(encrypted)

nanoTDFConfig, err := h.sdk.NewNanoTDFConfig()
if err != nil {
return nil, err
}

err = nanoTDFConfig.SetKasURL(h.platformEndpoint + kasUrlPath)
if err != nil {
return nil, err
}
err = nanoTDFConfig.SetAttributes(values)
if err != nil {
return nil, err
options := []sdk.NanoTDFOption{
sdk.WithKasURL(h.platformEndpoint + kasUrlPath),
sdk.WithNanoDataAttributes(values),
}
if ecdsaBinding {
nanoTDFConfig.EnableECDSAPolicyBinding()
options = append(options, sdk.WithECDSAPolicyBinding())
}
Comment on lines +14 to 20
Copy link
Copy Markdown

@Doom4535 Doom4535 Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to remove the need for the extra module inclusion of github.com/opentdf/platform/sdk by using the handler wrapped sdk? Something like:

options := []h.sdk.NanoTDFOption{
	h.sdk.WithKasURL(h.platformEndpoint + kasUrlPath),
	h.sdk.WithNanoDataAttributes(values),
}

if ecdsaBinding {
	options = append(options, h.sdk.WithECDSAPolicyBinding())
}


// TODO: validate values are FQNs or return an error [https://github.com/opentdf/platform/issues/515]
_, err = h.sdk.CreateNanoTDF(enc, bytes.NewReader(b), *nanoTDFConfig)
_, err := h.sdk.CreateNanoTDF(enc, bytes.NewReader(b), options...)
if err != nil {
return nil, err
}
Expand Down