Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions xtest/test_tdfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -518,13 +518,8 @@ def assert_tamper_error(

expected_error_oneof = [
b"tamper",
b"could not find policy in rewrap response", # For older versions of go sdk, we get "InvalidFileError" instead of "tamper".
]
match type:
case "wrap":
expected_error_oneof += [
b"InvalidFileError",
]
case "root" | "signature":
expected_error_oneof += [
b"IntegrityError",
Expand All @@ -541,6 +536,33 @@ def assert_tamper_error(
)


def assert_kas_request_error(
exc: subprocess.CalledProcessError, decrypt_sdk: tdfs.SDK
) -> None:
Comment thread
marythought marked this conversation as resolved.
"""Assert that a KAS request error was returned.

Used for policy binding failures where KAS rejects the request (400).
Accepts both the new error classification (KAS request error) and the
legacy classification (tamper) for backward compatibility with older
SDK versions.
"""
expected_patterns = [
# New classification: KAS request error
b"KAS request error",
b"rewrap request 400",
b"bad request",
b"InvalidArgument",
# Legacy classification: tamper (older SDK versions)
b"tamper",
b"InvalidFileError",
b"could not find policy in rewrap response",
]
pattern = b"|".join(re.escape(p) for p in expected_patterns)
assert re.search(pattern, exc.output, re.IGNORECASE), (
f"Expected KAS request or tamper error, got: [{exc.output}]"
)


## POLICY TAMPER TESTS


Expand Down Expand Up @@ -575,7 +597,7 @@ def test_tdf_with_unbound_policy(
decrypt_sdk.decrypt(b_file, rt_file, "ztdf", expect_error=True)
assert False, "decrypt succeeded unexpectedly"
except subprocess.CalledProcessError as exc:
assert_tamper_error(exc, "wrap", decrypt_sdk)
assert_kas_request_error(exc, decrypt_sdk)
Comment thread
marythought marked this conversation as resolved.

# Verify rewrap failure was logged (policy binding mismatch)
# FIXME: Audit logs are not present on failed bindings
Expand Down Expand Up @@ -609,7 +631,7 @@ def test_tdf_with_altered_policy_binding(
decrypt_sdk.decrypt(b_file, rt_file, "ztdf", expect_error=True)
assert False, "decrypt succeeded unexpectedly"
except subprocess.CalledProcessError as exc:
assert_tamper_error(exc, "wrap", decrypt_sdk)
assert_kas_request_error(exc, decrypt_sdk)
Comment thread
marythought marked this conversation as resolved.

# Verify rewrap failure was logged (policy binding mismatch)
# FIXME: Audit logs are not present on failed bindings
Expand Down
Loading