feat(acc): Add provider_acceptance_tests input for automated acceptance test setup#97
Merged
diofeher merged 5 commits intoopentofu:mainfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: hoivikaj <github@hoivik.co>
lbordowitz
reviewed
Mar 20, 2026
lbordowitz
left a comment
lbordowitz
left a comment
There was a problem hiding this comment.
On the face of it, this looks functional and ergonomic. Nice job!
I'm going to reach out to another maintainer who's more familiar with the setup-opentofu repo for a second opinion, since this is my first time reviewing a PR on this repo.
Contributor
Author
|
I noticed this got a thumbs up reaction from @diofeher -- is this still awaiting an additional review? |
Signed-off-by: hoivikaj <github@hoivik.co>
diofeher
approved these changes
Apr 15, 2026
Member
There was a problem hiding this comment.
This looks good, thanks for doing that work @hoivikaj!
A really small nit: provider_acceptance_test -> provider_acceptance_tests would be a better fit.
A rebase must be made, though.
P.S. Sorry for taking so long to get back to you, I have a few reviews related to some work you've done on my to-do list :)
Signed-off-by: Anthony Hoivik <38190936+hoivikaj@users.noreply.github.com>
…e_tests Signed-off-by: hoivikaj <github@hoivik.co>
hoivikaj
changed the title
diofeher
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #36
Used https://github.com/orgs/opentofu/discussions/975 as a framework for decisions.
Adds a new provider_acceptance_tests input that, when set to true, automatically exports the environment variables needed to run OpenTofu provider acceptance tests. This removes boilerplate from CI workflows that run provider acceptance tests.