Conversation
…options commit 7043a9f77c2ad8e937850fce6f95ab66592d624a upstream. The 'cpupower-set' tool has been enhanced with new features: commit f2ab555 ("cpupower: Add EPP value change support") commit df8776b ("cpupower: Add support for amd_pstate mode change") commit eb426fc ("cpupower: Add turbo-boost support in cpupower") However, the corresponding manpage was never updated. Add a basic description of these new options to the existing manpage. Commit description updated to fix checkpatch errors: Shuah Khan Intel-SIG: commit 7043a9f77c2a tools/power/cpupower: Add documentation for some recently introduced options Support cpupower turbo boost on Intel platforms Signed-off-by: Tor Vic <torvic9@mailbox.org> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> [ Zhang Rui: amend commit log ] Signed-off-by: Zhang Rui <rui.zhang@intel.com>
…h boost support.
commit 357d1fc38aad2cf4ea6626138cbf68299d20170c upstream.
The cpufreq subsystem has a generic sysfs interface for controlling boost
(/sys/devices/system/cpu/cpufreq/boost).
The sysfs interface can be used to enable boost control from the cpupower
command on non-x86 platforms as well. So, allow boost controlling
on non-x86 system if boost sysfs file exists.
The set subcommand enables/disables the boost feature using the following
syntax:
cpupower set --boost 1
cpupower set --boost 0
The --boost option is an alias for --turbo-boost. We provided the neutral
option name because the name "turbo boost" is specific to Intel technology.
The frequency-info subcommand displays the enabled/disabled state of
the boost feature as follows:
boost state support:
Active: yes (or no)
Intel-SIG: commit 357d1fc38aad cpupower: Allow control of boost feature on non-x86 based systems with boost support.
Support cpupower turbo boost on Intel platforms
Link: https://lore.kernel.org/r/20250522061122.2149188-3-fj5851bi@fujitsu.com
Signed-off-by: Shinji Nomoto <fj5851bi@fujitsu.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
[ Zhang Rui: amend commit log ]
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
commit 3817b1d34432d3d83a61576719570d04c341b7cd upstream.
On modern Intel platforms, the intel_pstate driver is commonly used and
it provides turbo boost control via
/sys/devices/system/cpu/intel_pstate/no_turbo.
However, cpupower doesn't handle this. it
1. shows turbo boost as "active" blindly for Intel platforms
2. controls turbo boost functionality via the generic
/sys/devices/system/cpu/cpufreq/boost sysfs interface only.
Enhance the cpupower tool to ensure the "--boost" command works
seamlessly on Intel platforms with intel_pstate driver running.
Without this patch,
$ echo 1 | sudo tee /sys/devices/system/cpu/intel_pstate/no_turbo
1
$ sudo cpupower frequency-info --boost
analyzing CPU 21:
boost state support:
Supported: yes
Active: yes
$ sudo cpupower set --boost 0
Error setting turbo-boost
$ sudo cpupower set --boost 1
Error setting turbo-boost
With this patch,
$ cat /sys/devices/system/cpu/intel_pstate/no_turbo
0
$ sudo cpupower set --boost 0
$ sudo cpupower frequency-info --boost
analyzing CPU 21:
boost state support:
Supported: yes
Active: no
$ cat /sys/devices/system/cpu/intel_pstate/no_turbo
1
$ sudo cpupower set --boost 1
$ sudo cpupower frequency-info --boost
analyzing CPU 28:
boost state support:
Supported: yes
Active: yes
$ cat /sys/devices/system/cpu/intel_pstate/no_turbo
0
Intel-SIG: commit 3817b1d34432 cpupower: Add intel_pstate turbo boost support for Intel platforms
Support cpupower turbo boost on Intel platforms
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
[ Zhang Rui: amend commit log ]
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support cpupower tool on Intel platforms
Test:
Tested with: lkvs:bm:cpupower:tests
On CWF/SRF:
No regression observed.
Improvement (2 tests):
lkvs:bm:cpupower:tests:boost_disable
lkvs:bm:cpupower:tests:boost_enable
Reason: Base failure (driver-limitation) resolved
On DMR:
No regression observed.
Improvement (2 tests):
lkvs:bm:cpupower:tests:boost_disable
lkvs:bm:cpupower:tests:boost_enable
Reason: Base failure (driver-limitation) resolved
1: tools/power/cpupower: Add documentation for some recently introduced options
2: cpupower: Allow control of boost feature on non-x86 based systems with boost support.
3: cpupower: Add intel_pstate turbo boost support for Intel platforms