Conversation
commit ff03ff3 upstream. The long names of the SMCA banks are only used by the MCE decoder module. Move them out of the arch code and into the decoder module. [ bp: Name the long names array "smca_long_names", drop local ptr in decode_smca_error(), constify arrays. ] Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/20231118193248.1296798-5-yazen.ghannam@amd.com Signed-off-by: priyanka-mani <DMani.Priyanka@amd.com> Signed-off-by: mohanasv2 <mohanasv@amd.com>
commit 47b744e upstream. Add HWID and McaType values for new SMCA bank types. Signed-off-by: Muralidhara M K <muralidhara.mk@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/20231102114225.2006878-3-muralimk@amd.com Signed-off-by: priyanka-mani <DMani.Priyanka@amd.com> Signed-off-by: mohanasv2 <mohanasv@amd.com>
commit bee9f4178b4a3fec70414c82ddc4bceff182f2ba upstream. Originally, the SMCA bank type enums were ordered based on processor documentation. However, the ordering became inconsistent after new bank types were added over time. Sort the bank type enums alphanumerically in most places. Sort the "enum to HWID/McaType" mapping by HWID/McaType. Drop redundant code comments. No functional changes. [ bp: Sort them alphanumerically. ] Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://patch.msgid.link/20260307163316.345923-2-yazen.ghannam@amd.com Signed-off-by: priyanka-mani <DMani.Priyanka@amd.com> Signed-off-by: mohanasv2 <mohanasv@amd.com>
commit b595a009726b706fdadedace90c54831e19188e2 upstream. Recent documentation updated the "CS" bank type name from "Coherent Slave" to "Coherent Station". Apply this change in the kernel also. Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://patch.msgid.link/20260307163316.345923-3-yazen.ghannam@amd.com Signed-off-by: priyanka-mani <DMani.Priyanka@amd.com> Signed-off-by: mohanasv2 <mohanasv@amd.com>
commit b90d398138ab3088d168cacb2c3d5248feaa1ef7 upstream. Recognize new SMCA bank types and include their short names for sysfs and long names for decoding. Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://patch.msgid.link/20260307163316.345923-4-yazen.ghannam@amd.com Signed-off-by: priyanka-mani <DMani.Priyanka@amd.com> Signed-off-by: mohanasv2 <mohanasv@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport AMD Venice MCA new bank type support to veLinux kernel 6.6
Patch series
Overall summary
This 5-patch series refactors and extends AMD SMCA bank type handling in the x86 MCE and EDAC subsystems. It moves long bank names into the decoder module, reorganizes SMCA bank type enums, and updates existing CS bank naming for better consistency with AMD documentation. The series also introduces support for new bank types such as MA_LLC, USR_DP, and USR_CP, along with additional SMCA bank definitions. Overall, the changes improve code maintainability, align the kernel with newer AMD hardware specifications, and enhance error decoding support for recent AMD processors.
Functional tests:
Kernel Configuration: The kernel was built with the following options enabled:
CONFIG_X86_MCE=y
CONFIG_X86_MCE_AMD=y
CONFIG_X86_MCE_INJECT=m
CONFIG_EDAC=y
CONFIG_EDAC_DECODE_MCE=m
CONFIG_EDAC_AMD64=m
CONFIG_AMD_ATL=m
CONFIG_AMD_NB=y
MCA / SMCA sanity
New SMCA bank type decoding
CS bank rename (user-visible ABI change)
Before backport: coherent_slave_*
After backport: coherent_station_*
Before: "Coherent Slave Ext. Error Code: ..."
After: "Coherent Station Ext. Error Code: ..." while the underlying error information remains unchanged.
Regression checks for existing bank types
Long-name table validation
Kernel stability