The additional compiler flags were added for CI consistency.#13281
Closed
OleksiiZaderykhinCapgemini wants to merge 1 commit into
Closed
The additional compiler flags were added for CI consistency.#13281OleksiiZaderykhinCapgemini wants to merge 1 commit into
OleksiiZaderykhinCapgemini wants to merge 1 commit into
Conversation
OleksiiZaderykhinCapgemini
added
category: CPU
…flags were added for GNUCC compiler also. So building errors on this CI check could be detected on ubuntu environment also.
OleksiiZaderykhinCapgemini
force-pushed
the
cpu_plugin_ci_consistency
branch
from
bf60bd0 to
53b1441
Compare
Contributor
Please, provide info where have you seen it.. |
|
|
||
| if(CMAKE_COMPILER_IS_GNUCC) | ||
| ie_add_compiler_flags(-Wno-all) | ||
| ie_add_compiler_flags(-Wno-all -Werror -Wundef -Wreturn-type -Wunused-variable -Wunused-value -Wswitch -Wformat -Wformat-security) |
Contributor
There was a problem hiding this comment.
why not to just fix -Wall ?
Contributor
Author
There was a problem hiding this comment.
why not to just fix
-Wall?
With -Wall the project will not compile. There will be errors related to the -Werror=sign-compare and -Werror=reorder flags that are not set in other build configurations and CI checks.
Contributor
Author
Hi @ilya-lavrenov, I saw it while preparing the PR. I use Ubuntu 18.04 environment for development and have no build errors there, but there were errors on Here you could see these additional flags (see the second line). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build_macos_release CI check has additional compiler flags. These flags were added for the GNUCC compiler also. So building errors on this CI check could be detected on the ubuntu environment also.