[CPU][RV64] implement vectorized im2col+GEMM convolution with fallback#35949
Open
strelkovkm wants to merge 19 commits into
Open
[CPU][RV64] implement vectorized im2col+GEMM convolution with fallback#35949strelkovkm wants to merge 19 commits into
strelkovkm wants to merge 19 commits into
Conversation
Reason: need to use local dir
aobolensk
reviewed
May 16, 2026
Contributor
There was a problem hiding this comment.
Please, get rid of all dependency updates, except onednn (CPU only)
| /tools/commit_slider/slider_cache/* | ||
| /src/plugins/intel_cpu/thirdparty/ComputeLibrary/build/arm_compute_version.embed | ||
| .github/GITHUB_OUTPUT | ||
|
|
Contributor
There was a problem hiding this comment.
Please, revert here as well
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Intel CPU plugin convolution implementation registration for RISC-V and adds root-level ignore patterns for local artifacts.
Changes:
- Adds a RISC-V
convolution_dnnl_ncsp_ncspexecutor registration before the existing ncsp reference-like entry. - Keeps quantized and depthwise-post-op configurations unsupported for the new RISC-V DNNL ncsp path.
- Adds several root-level directories to
.gitignore.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/plugins/intel_cpu/src/nodes/executors/convolution_implementations.cpp |
Adds a RISC-V DNNL ncsp convolution implementation entry. |
.gitignore |
Adds ignores for local model/report/package-style directories. |
Comment on lines
+279
to
+283
| OV_CPU_INSTANCE_RISCV64( | ||
| "convolution_dnnl_ncsp_ncsp", ExecutorType::Dnnl, OperationType::Convolution, | ||
| // supports | ||
| [](const ConvConfig& config, const MemoryFormatFilter& memoryFormatFilter) -> bool { | ||
| VERIFY(!isQuantized(config), UNSUPPORTED_SRC_PRECISIONS); |
Comment on lines
+291
to
+293
| CreateOptimalConfigDefault{{LayoutType::ncsp, LayoutType::ncsp, LayoutType::ncsp, LayoutType::ncsp}}, | ||
| AcceptsAnyShape<ConvAttrs>, | ||
| CreateDnnlDefault<DnnlConvolutionPrimitive, ConvAttrs>{} |
10 tasks
Contributor
|
Please, mention openvinotoolkit/oneDNN#312 in the PR description as a dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
im2col + GEMMapproach using RISC-V Vector (RVV) intrinsics. (oneDNN)Tickets:
AI Assistance: