[GPU] Fix GDN func test to use TEMPLATE plugin as reference#36081
Open
wine99 wants to merge 4 commits into
Open
[GPU] Fix GDN func test to use TEMPLATE plugin as reference#36081wine99 wants to merge 4 commits into
wine99 wants to merge 4 commits into
Conversation
The GPU functional test for GatedDeltaNet was failing on A770 because it used the CPU plugin as reference, which is not available on that test platform. Changes: - Add evaluate() method to GatedDeltaNet op, enabling the TEMPLATE plugin to evaluate it directly as a reference implementation. - Update the GPU functional test to use infer_on_template() instead of compiling on CPU. CVS-187512
github-actions
Bot
added
category: Core
Contributor
Author
|
@zhangYiIntel @isanghao Please take a look. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the GPU GatedDeltaNet functional test reference path by enabling TEMPLATE-based evaluation instead of relying on the CPU plugin, which may be unavailable on the target GPU test platform.
Changes:
- Adds
evaluate()/has_evaluate()support forov::op::internal::GatedDeltaNet. - Implements an f32 reference GatedDeltaNet algorithm in core.
- Updates the GPU functional test to compare GPU outputs against
infer_on_template().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/core/dev_api/openvino/op/gated_delta_net.hpp |
Declares evaluator overrides for the internal GatedDeltaNet op. |
src/core/src/op/gated_delta_net.cpp |
Adds f32 evaluator implementation used by TEMPLATE inference. |
src/plugins/intel_gpu/tests/functional/single_layer_tests/gated_delta_net.cpp |
Replaces CPU reference inference with TEMPLATE reference inference. |
Contributor
Author
|
@zhangYiIntel Suggestions applied |
zhangYiIntel
approved these changes
May 29, 2026
Contributor
zhangYiIntel
left a comment
zhangYiIntel
left a comment
There was a problem hiding this comment.
LGTM for kernel side.
Contributor
Author
|
@mitruska Could you take a look |
Contributor
|
build_jenkins |
praasz
requested changes
Jun 1, 2026
github-actions
Bot
added
category: TEMPLATE
Contributor
|
build_jenkins |
Contributor
Author
|
@p-durandin Could you help trigger CI again |
Contributor
|
build_jenkins |
Contributor
Author
|
@praasz Could you take a look again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Problem:
The GPU functional test
smoke_GatedDeltaNetStaticwas failing on A770 (Linux) because it used the CPU plugin as a reference for output comparison, but the CPU plugin is not registered on that test platform.Solution:
evaluate()method toGatedDeltaNetop — implements the reference GDN algorithm directly in the core op, enabling the TEMPLATE plugin to evaluate it.core.compile_model(model, "CPU")withov::test::utils::infer_on_template(), which uses the TEMPLATE plugin (interpreter backend) as reference.Changes:
src/core/dev_api/openvino/op/gated_delta_net.hpp— declareevaluate()andhas_evaluate()overridessrc/core/src/op/gated_delta_net.cpp— implementevaluate()with the GDN reference algorithm (f32 only)src/plugins/intel_gpu/tests/functional/single_layer_tests/gated_delta_net.cpp— useinfer_on_templateinstead of CPU plugin