-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[OV MX][GPU] Fix MoE model cache load crashes #36152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xzhan34
wants to merge
4
commits into
openvinotoolkit:master
Choose a base branch
from
xzhan34:qwen3_omni_moe_dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+371
−3
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fbdbb78
GPU plugin: gate MOE3GemmFusedCompressed fusion on oneDNN availability
xzhan34 0d8e0c7
GPU: fix std::bad_function_call crash on compiled model cache load
xzhan34 17060d8
GPU: serialize MoE prefill execution flags in compiled model cache
xzhan34 b195f83
Add unit tests for GPU plugin cache serialization and stability fixes
xzhan34 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
src/plugins/intel_gpu/tests/unit/module_tests/dispatch_data_func_test.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // Copyright (C) 2018-2026 Intel Corporation | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| // Regression tests for the null-guard added to DispatchDataFunc::operator(). | ||
| // Before the fix, calling a DispatchDataFunc constructed from nullptr would | ||
| // invoke a null std::function and throw std::bad_function_call. | ||
|
|
||
| #include "test_utils.h" | ||
| #include "common_utils/kernel_generator_base.hpp" | ||
|
|
||
| using namespace ov::intel_gpu; | ||
|
|
||
| TEST(dispatch_data_func, null_func_does_not_crash) { | ||
| DispatchDataFunc func{nullptr}; | ||
| KernelData kd; | ||
| RuntimeParams params; | ||
|
|
||
| ASSERT_NO_THROW(func(params, kd, nullptr)); | ||
| } | ||
|
|
||
| TEST(dispatch_data_func, valid_func_is_called) { | ||
| bool called = false; | ||
| DispatchDataFunc func{[&called](const RuntimeParams&, KernelData&, ImplRuntimeParams*) { | ||
| called = true; | ||
| }}; | ||
| KernelData kd; | ||
| RuntimeParams params; | ||
|
|
||
| func(params, kd, nullptr); | ||
| ASSERT_TRUE(called); | ||
| } | ||
|
|
||
| TEST(dispatch_data_func, default_constructed_is_null_safe) { | ||
| // Default-constructed KernelData has update_dispatch_data_func{nullptr}. | ||
| KernelData kd; | ||
| RuntimeParams params; | ||
|
|
||
| ASSERT_NO_THROW(kd.update_dispatch_data_func(params, kd, nullptr)); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.