Complete comprehensive package review for gdho #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements all fixes identified during the openwashdata package review: ## Data Processing (Issue #3) - Fixed country name cleaning by removing commas - Removed 8 duplicate rows using distinct() - Changed data types from factor to integer to match dictionary - Separated ope_original_currency into two columns (amount and currency_code) - Documented imputed staff categories - Updated dictionary generation for new columns ## Documentation (Issue #4) - Added proper roxygen2 documentation with @source tags - Regenerated all documentation files - Updated column counts in documentation (now 35 for gdho, 275 for gdho_full) - Kept vignette in articles/ subdirectory as requested ## Testing (Issue #5) - Added testthat framework - Created comprehensive data tests - Removed backup CITATION file ## Other improvements - Installed missing writexl package - Fixed across() deprecation warning - Rebuilt pkgdown website with analytics tracking - Package now passes R CMD check with 0 errors, 0 warnings The package is now ready for publication with 4548 rows (after removing duplicates). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
14 tasks
This was referenced Jul 3, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements all fixes identified during the openwashdata package review:
Data Processing (Issue #3)
Documentation (Issue #4)
Testing (Issue #5)
Other improvements
The package is now ready for publication with 4548 rows (after removing duplicates).
🤖 Generated with Claude Code