This repository was archived by the owner on Dec 20, 2023. It is now read-only.
add Float number print in DataElement::Parser::ParseData#576
Open
yunhanw-google wants to merge 1 commit into
Open
add Float number print in DataElement::Parser::ParseData#576yunhanw-google wants to merge 1 commit into
yunhanw-google wants to merge 1 commit into
Conversation
gerickson
reviewed
May 4, 2020
gerickson
left a comment
gerickson
left a comment
Contributor
There was a problem hiding this comment.
Are we now actively using floating point types in schema? If so, which one(s)?
yunhanw-google
force-pushed
the
feature/add_float_point_print
branch
from
3081c2f to
0669aac
Compare
Contributor
Author
https://github.com/openweave/openweave-core/blob/master/src/test-apps/schema/nest/test/trait/TestATrait.h#L180 |
Contributor
Author
|
Just update the corresponding test in this PR. thanks |
jaylogue
reviewed
May 4, 2020
| err = aReader.Get(value_fp); | ||
| SuccessOrExit(err); | ||
|
|
||
| PRETTY_PRINT_SAMELINE("%lf, ", value_fp); |
Contributor
There was a problem hiding this comment.
This may run into problems on platforms where printf doesn't support float.
Contributor
Author
There was a problem hiding this comment.
maybe we can add the feature flag on it? WEAVE_CONFIG_SUPPORT_FLOAT_PRINT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.