asusuimage: fix fs_offset extraction in show_info#66
Open
matjon wants to merge 1 commit intoopenwrt:masterfrom
Open
asusuimage: fix fs_offset extraction in show_info#66matjon wants to merge 1 commit intoopenwrt:masterfrom
matjon wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This code was apparently intended to look for FS_OFFSET_PREFIX and then read the big-endian 24-bit value just after it. Instead, it did always read the value from a fixed offset. This fixes using bogus (or zero) values of `fs_offset` when analysing TRXv2 images for Asus RT-AX53U. Now the values agree with what the `binwalk` tool prints. This patch modifies the show_info() function, which is used only for firmware analysis and not in an OpenWRT build. Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was apparently intended to look for FS_OFFSET_PREFIX and then read the big-endian 24-bit value just after it. Instead, it did always read the value from a fixed offset.
This fixes using bogus (or zero) values of
fs_offsetwhen analysing TRXv2 images for Asus RT-AX53U. Now the values agree with what thebinwalktool prints.This patch modifies the show_info() function, which is used only for firmware analysis and not in an OpenWRT build.
cc: @remittor